Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #0
Problem/Motivation
Before:
After:
Proposed resolution
I think we should fix it in breadcrumb builder as can be seen in the attached patch #0
@dawehner suggested we should fix it in \Drupal\field_ui\Routing\RouteSubscriber::routes
see #1 and http://privatepaste.com/2b58ea47c8.
Remaining tasks
Decide is it ok to fix it in breadcrumb builder? Or do we have to fix fields routing title.
User interface changes
See after image
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#20 | interdiff.txt | 1.52 KB | jibran |
#20 | 2147685-20.patch | 3.62 KB | jibran |
#14 | 2147685-14.patch | 3.58 KB | jibran |
#14 | interdiff.txt | 1.61 KB | jibran |
#14 | 2147685-test-only.patch | 1.61 KB | jibran |
Comments
Comment #1
jibranHere is the other approach approved by @dawehner.
New After
Comment #2
amateescu CreditAttribution: amateescu commentedIs there a reason for using the FieldUi class instead of the class that displays the form (FieldInstanceEditForm)?
Comment #3
jibranIt is just a static code we can move it around if the approach is fine we can move it to anyplace.
Comment #4
jibranComment #6
amateescu CreditAttribution: amateescu commentedThe approach seems fine :) Let's move it to a getTitle() method on FieldInstanceEditForm and also remove $form['#title'] from that form.
Comment #7
jibranMoved
\Drupal\field_ui\Form\FieldInstanceEditForm::getTitle
. I don't think we should remove$form['#title']
Before Removing
After Removing
Title is all messed up so I think we should keep it.
Comment #8
amateescu CreditAttribution: amateescu commentedSure, let's keep it then.
'_form' needs to be moved below "array(", on it's own row :)
Comment #9
jibranComment #10
amateescu CreditAttribution: amateescu commentedThanks!
Comment #12
jibranIt is a quick fix IMHO.
Comment #13
webchickCan we get a quick test for this?
Comment #14
jibranHere are some tests.
Comment #18
jibran14: 2147685-14.patch queued for re-testing.
Comment #19
amateescu CreditAttribution: amateescu commentedWe normally use present tense in test assertions, so how about 'Field label is correct in the breadcrumb of the field settings page.'
And 'Field label is correct in the breadcrumb of the field delete page.'
Comment #20
jibranFixed. But
In my defiance.
Comment #21
amateescu CreditAttribution: amateescu commentedI think those examples are fine as they are, but "was correct" sounds to me more like "it was correct at some point but it's not necessarily the case anymore". It's also probably just a matter of preference, so thanks for the quick update :)
Comment #22
webchickCommitted and pushed to 8.x. Thanks!