Follow-up from #2078867: Convert _form_test_* functions to classes.

Part of #1971384: [META] Convert page callbacks to controllers

Convert below form callback to new controller (form/callback).

ajax_forms_test_ajax_commands_form
ajax_forms_test_lazy_load_form
ajax_forms_test_simple_form
ajax_forms_test_validation_form

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#5 ajax-test-2147009-5.patch32.18 KBtim.plunkett
#3 system.ajax_forms_test.forms-2147009-3.patch23.97 KBrosk0

Comments

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Title: Covert all menu items to new controller in ajax_forms_test module » Covert ajax_forms_test_lazy_load_form, ajax_forms_test_simple_form, ajax_forms_test_validation_form to new controller
Issue summary: View changes
Parent issue: » #1971384: [META] Convert page callbacks to controllers
rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Assigned: Unassigned » rosk0

Patch is on his way.

rosk0’s picture

rosk0
he/him
Primary language Russian
Location Wellington
commented
Title: Covert ajax_forms_test_lazy_load_form, ajax_forms_test_simple_form, ajax_forms_test_validation_form to new controller » Covert all menu items to new controller in ajax_forms_test module
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new system.ajax_forms_test.forms-2147009-3.patch23.97 KB

Converted ajax_forms_test_lazy_load_form, ajax_forms_test_simple_form, ajax_forms_test_validation_form forms and incorporated patch from #2132465: Convert ajax_forms_test_ajax_commands_form to new controller, this changes must go together not to leave garbage like AjaxFormsTestForm(see diff) in place.
Also restoring original title and description

Status: Needs review » Needs work

The last submitted patch, 3: system.ajax_forms_test.forms-2147009-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Covert all menu items to new controller in ajax_forms_test module » Convert all forms in ajax_forms_test module to FormInterface
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new ajax-test-2147009-5.patch32.18 KB

Your comment in #3 said you merged the two issues, but you were missing the actual form class.
My only other changes were changing t() to $this->t(), all other work was yours, so I'm going to RTBC (passed locally).

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks good.

Committed and pushed to 8.x. Thanks!

  • Commit cf902f2 on 8.x by webchick: 
    Issue #2147009 by tim.plunkett, RoSk0 | vijaycs85: Convert all forms in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.