The menu link settings in node forms talk about smaller weights and larger weights. The way this is phrased, this is about physical objects called weights, such as the ones you use to exercise with in the gym. The UI, however, uses weight as something's property, like mass * gravitational force is a person's weight. These weights are not small or large, but low or high.

CommentFileSizeAuthor
#1 after.png10.71 KBxano
#1 before.png10.63 KBxano
#1 drupal_2146817_1.patch579 bytesxano

Comments

xano’s picture

Assigned: xano » Unassigned
Status: Active » Needs review
StatusFileSize
new579 bytes
new10.63 KB
new10.71 KB

BEFORE

AFTER

longwave’s picture

Title: "smaller weights" > "lower weights" » Use "lower weights" instead of "smaller weights"

I was confused by the old title as > can also mean better/greater than, this should be clearer.

xano’s picture

Thanks. What do you think about the change?

longwave’s picture

Status: Needs review » Reviewed & tested by the community

It does make more sense this way. I thought we had similar examples in core, but I actually can't find any. I also considered "lighter weight" and "heavier weight" but they are not immediately intuitive, so I think the suggested patch is the best option.

webchick’s picture

Component: menu system » user interface text
Assigned: Unassigned » jhodgdon

Probably makes sense for Jennifer to eyeball this one.

jhodgdon’s picture

I think this is an excellent change.

Sorry I didn't see this until today. Apparently in the current d.o issue system, if you assign someone an issue they do not automatically "follow" it, so this did *not* appear in My Issues automatically. I don't check "issues assigned to me" very often.

I'll file an issue on that in the d.o upgrade queue if it's not already there.

jhodgdon’s picture

Apparently that bug about assigning was fixed on Dec 10.
#2112421: Regression: assigned user is no longer automatically following the issue

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
webchick’s picture

Priority: Normal » Minor

Committed and pushed to 8.x. Thanks!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.