The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The module's CSS is using important! rules that ruin themes CSS.
I assume this was due to a specific theme, but it shouldn't be assuming any style.
If the CSS rules need to be there at least remove the important.
In attachment is a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | pdm-dev-messages-js.patch | 1.68 KB | erikhopp |
| #2 | pdm-important-css.patch | 248 bytes | erikhopp |
| remove_theme_specific_rules.patch | 670 bytes | kyuubi |
Comments
Comment #1
erikhopp commentedI second this. I also had to remove the "!important"s. They are unnecessary and interfere with probably most themes.
Comment #2
erikhopp commentedAttached is a patch which is a little less destructive than the initial one. This simply removes the '!important' declarations.
Comment #3
erikhopp commentedIn order to make the dismissal of messages correct from a visual standpoint while also removing the '!important' CSS declaration, we should also close the entire dismissed .messages div, rather than simply the .pdm-message-wrapper. A patch for that is attached. the entire patch for this bug report should then include the attached patch and the 'pdm-important-css.patch' patch.
Comment #4
kyuubi commentedHi erikhopp,
Yes I also had to redo the js to close the .messages div instead of the wrapper.
Your patch seems to work fine.
Cheers,
Duarte
Comment #5
Andre-Blooks good
Comment #7
soyarma commentedThanks! Patches applied.
Comment #8
soyarma commentedI applied both the CSS and the JS, but then I realized, upon testing, that the JS closes then entire messages 'type' wrapper when any dismiss within it is clicked.
The 'messages' div is for an entire group. A group being error, warning, success, info, etc... This means that if you had 3 'success' messages in a section, clicking dismiss on any of them would hide them all, but only dismiss the one you clicked.