This module is small, fast and does what it says. In short it's the bees knees.

However the flyout form does get in the way on admin screens that don't have a URL that starts with "admin"; the module could do more to block the flyout from being added to, e.g., the node edit and node add pages and the Media Browser popup (if you're using the Media module). There are probably others as well.

One simple fix can change all this. Instead of checking if arg(0) == 'admin', ladies and gentlemen, I introduce path_is_admin().

CommentFileSizeAuthor
#1 simplemeta-path-is-admin-2145345.patch974 bytesjwilson3

Comments

jwilson3’s picture

StatusFileSize
new974 bytes
jwilson3’s picture

Status: Active » Needs review
jwilson3’s picture

Issue summary: View changes
Anthony Goode’s picture

Hi,
In my case the simplemeta tab does not appear on admin/content/ although you can see on the code that the menu items are set on hook_menu() implementation. I have done a simple fixing:

In the simplemeta.module file (module version 7.x-1.1):

/**
 * Implements hook_menu()
 */
function simplemeta_menu() {
  $items = array();
  $items['admin/content/simplemeta'] = array(
    'title' => 'SimpleMeta',
    'page callback' => 'simplemeta_meta_list',
    'access arguments' => array('administer simplemeta'),
    'file' => 'simplemeta.admin.inc',
  );

I have added it as a tab on the content administration page:

    'type' => MENU_LOCAL_TASK,

It works for me, I hope some one else finds it useful.

Cheers!

jwilson3’s picture

Um, @Anthony Goode, that is a completely separate problem and fix from what this issue is about, mind creating a separate issue?

This issue is about the flyout tab that sits on the left side of the screen on all front-end pages, that sometimes ends up appearing on some admin pages.

This issue is NOT about the simplemeta admin page and its tab at /admin/content/simplemeta

  • Commit c95ebb3 on 7.x-1.x by antongp:
    Issue #2145345 by jwilson3: Hide flyout on all admin pages (including...
jwilson3’s picture

Status: Needs review » Fixed

^ Cool. Thanks for the commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.