Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Patch fixes 34 places in core that use the phrase "take sure" when what is meant is "make sure". All of these appear in code that was formerly part of Views before Views was brought into core.
All of these changes are either in comments or in the output of assert() in Test cases.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | interdiff.txt | 892 bytes | longwave |
| #1 | 2145083-take-sure-1.patch | 17.76 KB | longwave |
| take-sure.patch | 17.77 KB | tr |
Comments
Comment #1
longwaveLooks good. One of the comments still had incorrect grammar, so I fixed that up as well.
Comment #2
dawehnerI really wonder who could have made all those mistakes.
Comment #3
tim.plunkettI'd much rather close this as won't fix, but I'm just nostalgic.
Comment #4
dead_armIt's a feature not a bug :)
Comment #5
jhodgdonThanks! I found a couple of other grammatical bad spots in those lines and cheated and fixed them at the commit as well, since it's just comments/docs/test assertion text. Committed to 8.x.
Comment #6
nod_Patch changes JS files, tagging.