\Drupal\Core\Plugin\ContextAwarePluginBase extends \Drupal\Component\Plugin\ContextAwarePluginBase, so it does not inherit any of \Drupal\Core\Plugin\PluginBase wrapping code.

CommentFileSizeAuthor
#8 drupal_2144701_8.patch2.52 KBXano
#8 interdiff.txt844 bytesXano
#3 drupal_2144701_3.patch2.26 KBXano
#1 drupal_2144701_1.patch1.59 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Xano » Unassigned
Status: Active » Needs review
FileSize
drupal_2144701_1.patch1.59 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2144701_1.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
drupal_2144701_3.patch2.26 KB
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Issue tags: +PHPUnit

This also allows ConditionPluginBase and child classes to be tested through PHPUnit.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

I am glad that things like this will be way better in the future.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/lib/Drupal/Core/Plugin/ContextAwarePluginBase.php
@@ -54,4 +54,47 @@ public function setContextValue($name, $value) {
+      $this->translationManager = \Drupal::getContainer()->get('string_translation');

Any reason to not use \Drupal::translation?

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

I just copied this verbatim from \Drupal\Core\Plugin\PluginBase.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
FileSize
interdiff.txt844 bytes
drupal_2144701_8.patch2.52 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.