Suggested commit message:
Issue #2143415 by YesCT, mikeryan, marvil07, bdone, chx: Migrate fixes
Here's a potpourri of small fixes that went into the sandbox since commit. Notable changes:
- needsUpdate has been renamed to sourceRowStatus in #2140201: Rename map needs_update column
- mapTable to mapTableName and messageTable to messageTableName in #2142111: Map/message table name getters
- MigrateExecutable::getTimeLimit is now functional.
- lookupSourceID and lookupDestinationID now returns a list of identifier values instead of an associated array in #2137517: Write PHPUnit tests for SQL.php: lookupDestinationID()
- FakeSelect works after a FakeInsert/Update/Merge. Ongoing discussion on the database contents between classes in #2142285: Database contents not sufficiently persistent
- Doxygen fixes
| Comment | File | Size | Author |
|---|---|---|---|
| migrate_2a.patch | 31.87 KB | chx |
Comments
Comment #1
chx commentedComment #2
chx commentedComment #3
dawehnerSP: do you have a tag for all migrate issues?
Regarding the pace question in the other issue: at some point we just switch from sandbox/module development to use the core issue queue all the time.
Just for example this change is really nice!
It took me a while to understand how this variable looks like. Can we document that better in a follow up? Additional, what is the reason for making this public?
<3
Comment #4
chx commenteddatabaseContents is very well documented on FakeSelect.
Comment #5
alexpottCommitted 0d61dd8 and pushed to 8.x. Thanks!
Did a minor doc fix for spelling and formatting on the way in. Yes I know we are referring to sql commands but I think the capitalisation is unnecessary and UPDATE'd is fugly - plus this would the fist instance of this in our codebase.