Problem/Motivation

Language options "- Not specified - " and "- Not applicable -" appear to the user as being children to the previous language option within the language configuration form element, especially as more options follow after these two options.

Proposed resolution

Proposed solution is to move these two options to the end of the listing. Before/after:

Original options
Reordered options

It makes more sense to move up these options also because the *default* value of the select box is "Site default (XZY)", which this way is at the top instead of the middle of the list.

Remaining tasks

usability review done in #13 by @Bojhan
Commit. :)

User interface changes

See above.

API changes

None.

Comments

ti2m’s picture

Status: Active » Needs review
StatusFileSize
new1.2 KB

Status: Needs review » Needs work

The last submitted patch, 1: language_options_order-2143013-1.patch, failed testing.

The last submitted patch, 1: language_options_order-2143013-1.patch, failed testing.

ti2m’s picture

Status: Needs work » Needs review
gábor hojtsy’s picture

Would be good to have a screenshot of this change to see how it helps :D

Status: Needs review » Needs work

The last submitted patch, 1: language_options_order-2143013-1.patch, failed testing.

gábor hojtsy’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: language_options_order-2143013-1.patch, failed testing.

ti2m’s picture

gábor hojtsy’s picture

ti2m’s picture

Issue summary: View changes

The last submitted patch, 1: language_options_order-2143013-1.patch, failed testing.

Bojhan’s picture

This looks better :)

gábor hojtsy’s picture

gábor hojtsy’s picture

Issue summary: View changes
Status: Needs work » Reviewed & tested by the community
Issue tags: +Quick fix

Updated issue summary, moving to RTBC given the random fails are now gone and based on feedback from Bojhan.

gábor hojtsy’s picture

Fix tag name.

yesct’s picture

Issue summary: View changes

still applies. tried it manually, works great. also read the patch and code changes look good too.

webchick’s picture

Status: Reviewed & tested by the community » Needs review

Hm. While I think this is certainly better than it was, there's still the chance for someone to think that these are sub-items of German because the " - " character is used.

If we used a different character set, such as "[Not applicable]" I think that confusion might go away. That could possibly introduce inconsistency with other places in core though; presumably that's why the " - " character was chosen.

I'm comfortable committing this since it definitely makes things better than they are, so...

Committed and pushed to 8.x. Thanks!

...but leaving at needs review for a little further discussion on the bug in the OP.

gábor hojtsy’s picture

Status: Needs review » Fixed
Issue tags: -sprint

Does not seem like a discussion about this continued in the past 4 days. The '-' signifier is used in concert with other '- None -' options in Drupal. This is Drupal's standard to signify "none" options, and these languages are such 'none' options.

Bojhan’s picture

Status: Fixed » Needs review

Gábor, can we just leave this open for a while? I like all the managing, but some things just need a bit of time. I agree with @Angie that this is OK, but not very ideal.

znerol’s picture

Status: Needs review » Fixed

Discussion did not take place in months, closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.