This is a subissue of #2012776: [META] Improve validation constraint test coverage

This is a test for the Constraint Validation: EntityTypeConstraintValidator

CommentFileSizeAuthor
#11 d8_entity_type_constraint.interdiff.txt663 bytesfago
#11 d8_entity_type_constraint.patch2.82 KBfago
#7 drupal8.2142999-EntityType-constraint-test.drupal8.2142999-7.patch2.81 KBstefan.r
#5 drupal8.2142999-EntityType-constraint-test.drupal8.2142999-5.patch2.77 KBstefan.r
#1 drupal8.2142999-EntityType-constraint-test.drupal8.2142999-1.patch2.79 KBstefan.r

Comments

stefan.r’s picture

stefan.r commented
Status: Active » Needs review
StatusFileSize
new drupal8.2142999-EntityType-constraint-test.drupal8.2142999-1.patch2.79 KB
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

Patch looks good, thanks -> setting RTBC.

It will need a re-roll to move it to the entity component tests when #1893772: Move entity-type specific storage logic into entity classes got in though.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: Unassigned » fago
Status: Reviewed & tested by the community » Needs review

Sorry, I don't quite grok that. :( #1893772: Move entity-type specific storage logic into entity classes was committed months ago.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: fago » Unassigned
Status: Needs review » Needs work

Oh, ok. I think you meant #2137301: Move entity constraints under the Entity component instead.

That was just committed, so this will need a re-roll now.

stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.2142999-EntityType-constraint-test.drupal8.2142999-5.patch2.77 KB

Status: Needs review » Needs work

The last submitted patch, 5: drupal8.2142999-EntityType-constraint-test.drupal8.2142999-5.patch, failed testing.

stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review
StatusFileSize
new drupal8.2142999-EntityType-constraint-test.drupal8.2142999-7.patch2.81 KB
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

@webchick: Indeed, sry for that.

@stefan.r: Thanks, looks good again.

xjm’s picture

xjm
she/her
Primary language English
commented

7: drupal8.2142999-EntityType-constraint-test.drupal8.2142999-7.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: drupal8.2142999-EntityType-constraint-test.drupal8.2142999-7.patch, failed testing.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs work » Needs review
StatusFileSize
new d8_entity_type_constraint.patch2.82 KB
new d8_entity_type_constraint.interdiff.txt663 bytes

Re-rolled to account for the typed_data_manager service name change.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented 
+++ b/core/modules/system/lib/Drupal/system/Tests/Entity/EntityTypeConstraintValidatorTest.php
@@ -0,0 +1,73 @@
+  public static function getInfo() {
...
+  public function setUp() {

doc block missing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

RTBC if green.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

11: d8_entity_type_constraint.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.