Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
typed data system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Nov 2013 at 10:11 UTC
Updated:
29 Jul 2014 at 23:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
stefan.r commentedComment #2
fagoPatch looks good, thanks -> setting RTBC.
It will need a re-roll to move it to the entity component tests when #1893772: Move entity-type specific storage logic into entity classes got in though.
Comment #3
webchickSorry, I don't quite grok that. :( #1893772: Move entity-type specific storage logic into entity classes was committed months ago.
Comment #4
webchickOh, ok. I think you meant #2137301: Move entity constraints under the Entity component instead.
That was just committed, so this will need a re-roll now.
Comment #5
stefan.r commentedComment #7
stefan.r commentedComment #8
fago@webchick: Indeed, sry for that.
@stefan.r: Thanks, looks good again.
Comment #9
xjm7: drupal8.2142999-EntityType-constraint-test.drupal8.2142999-7.patch queued for re-testing.
Comment #11
fagoRe-rolled to account for the typed_data_manager service name change.
Comment #12
jibrandoc block missing.
Comment #13
jibranRTBC if green.
Comment #14
alexpott11: d8_entity_type_constraint.patch queued for re-testing.
Comment #15
webchickCommitted and pushed to 8.x. Thanks!