Replace getAdminPath() with getAdminRouteInfo() in Field UI

getAdminRouteInfo() was actually pointing to the field UI overview page, that was my fault way back in #1963394: ConfirmFormBase::getCancelPath() should allow for a route

This doesn't feel WSCCI related to me...

It's just menu stuff. Needs some reworking though.

Comments 2-8 were just retests and fails, I removed them.

It was a subdir install issue...

16: field_ui-2141329-16.patch queued for re-testing.

Rerolled.

Thanks Xano :)

Reroll.

+++ b/core/modules/field/lib/Drupal/field/Entity/FieldInstance.php
@@ -511,21 +511,25 @@ public function isTranslatable() {
+  protected function uriPlaceholderReplacements() {
+    if (empty($this->uriPlaceholderReplacements)) {

I am not sure whether I can support that crappyness. Why do we have the url generator if we don't use it at all and rebuild it based on pure string replacement. I know it is kind of out of scope of this issue, though is changes part of it and moves it to the base class.

Opened #2167641: EntityInterface::uri() should use route name and not path to address #23.

22: admin-path-2141329-22.patch queued for re-testing.

1. +++ b/core/lib/Drupal/Core/Entity/EntityManager.php
   @@ -296,29 +296,16 @@ public function getForm(EntityInterface $entity, $operation = 'default', array $
   -  public function getAdminRouteInfo($entity_type, $bundle) {
   
   +++ b/core/lib/Drupal/Core/Entity/Entity.php
   index bffc91b..b26ed40 100644
   --- a/core/lib/Drupal/Core/Entity/EntityManager.php
   
   --- a/core/lib/Drupal/Core/Entity/EntityManager.php
   +++ b/core/lib/Drupal/Core/Entity/EntityManager.php
   

   Wow, I would have not expected that!

2. +++ b/core/modules/field_ui/lib/Drupal/field_ui/FieldListController.php
   @@ -111,8 +111,12 @@ public function buildRow(EntityInterface $field) {
   +        $usage[] = \Drupal::l($this->bundles[$field->entity_type][$bundle]['label'], $route_info['route_name'], $route_info['route_parameters']);
   

   I just wonder why we don't inject stuff properly here.

1) Yeah, me neither. Glad to have it fixed before it breaks.

2) I didn't inject it because I thought there was an issue about list controllers getting the link/url generator passed to it, but I can't find that. I'll look more and open an issue if there isn't one.

22: admin-path-2141329-22.patch queued for re-testing.

Unfortunately, needs a re-roll at this point. I'll try and get it in tonight/tomorrow.

Went through a bunch of dumb questions with Tim on IRC, the only one that means any work for this patch is:

+++ b/core/modules/field_ui/lib/Drupal/field_ui/DisplayOverviewBase.php
@@ -105,8 +105,8 @@ public function buildForm(array $form, array &$form_state, $entity_type = NULL,
+      drupal_set_message($this->t('There are no fields yet added. You can add new fields on the <a href="@link">Manage fields</a> page.', array('@link' => $this->url($route_info['route_name'], $route_info['route_parameters']))), 'warning');
...
+          drupal_set_message($this->t('The %display_mode mode now uses custom display settings. You might want to <a href="@url">configure them</a>.', array('%display_mode' => $display_mode_label, '@url' => $this->url($route['route_name'], $route['route_parameters'], $route['options']))));

The latter is passing $route_info['options'], the former is not. (Actually nowhere else seems to pass 'options' either in a quick scan.)

Meant to do this.

Happily rerolled after the excellent #2144919: Allow widgets and formatters for base fields to be configured in Field UI.

Only change was ensuring that we pass the options along to everything, as pointed out by @webchick.

Is there a followup to get rid of $this->url($route_info['route_name'], $route_info['route_parameters'], $route_info['options'])

Yep

Ahem.

Ok great, getting this in while it's hot. :)

Committed and pushed to 8.x. Thanks!

Marking for change notice.

Made one on https://drupal.org/node/2174429