hook_config_translation_info and hook_config_translation_info_alter() reference *.configuration_translation.yml files, but the file name format should be *.config_translation.yml. This is a minor documentation bug that may confuse some people.

CommentFileSizeAuthor
#1 drupal_2140803_1.patch1.36 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: hook_config_translation_info() docblock references incorrect YAML file » hook_config_translation_info(_alter)() docblock references incorrect YAML file
Assigned: xano » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new drupal_2140803_1.patch1.36 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

This does not look correct to me.

I'm seeing files with names like config_translation.local_tasks.yml, config_translation.routing.yml, etc. They are not *.config_translation.yml. Or am I missing something?

Oh, I see, those are the ones in config_translation module. Then there is system.config_translation.yml.

What's the difference, and why are the naming conventions different?

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

config_translation.local_tasks.yml is a *.local_tasks.yml file, and that type is defined by other parts of core. *.config_translation.yml is a type of file defined by config_translation that can be implemented by other modules. However, that's not the problem. The problem is that there is no configuration_translation, but we only ever use config_translation.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Got it. Patch looks fine and I'll get it committed sometime soon.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looking for easy pickin's tonight, so yoink! :)

Committed and pushed to 8.x. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

good catch, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.