Remove views_cache_get/set functions

Nice work!

1. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
   @@ -148,23 +153,23 @@ public function initDisplay(ViewExecutable $view, array &$display, array &$optio
   -    static $unpack_options = array();
   ...
   +        static::$unpackOptions[$cid] = $this->options;
   ...
   +        $this->options = static::$unpackOptions[$cid];
   

   It feels wrong to still have static functions but I agree that this is out of scope here.

2. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
   @@ -148,23 +153,23 @@ public function initDisplay(ViewExecutable $view, array &$display, array &$optio
   +      $cid = 'unpackOptions:' . hash('sha256', serialize(array($this->options, $options))) . ':' . language(Language::TYPE_INTERFACE)->id;
   

   You can also use the languageManager service as alternative to this function call.

3. +++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
   @@ -148,23 +153,23 @@ public function initDisplay(ViewExecutable $view, array &$display, array &$optio
   +        $cache = cache('views_info')->get($cid);
   ...
   +          cache('views_info')->set($cid, $this->options);
   

   Can we replace that with \Drupal::cache() right now?

+++ b/core/modules/views/tests/Drupal/views/Tests/Plugin/display/PathPluginBaseTest.php
@@ -67,18 +67,41 @@ protected function setUp() {
+    $value_map = array(
+      array('skip_cache', TRUE),
+      array('display_extenders', array()),
+    );
+
+    $config = $this->getMockBuilder('Drupal\Core\Config\Config')
+      ->disableOriginalConstructor()
+      ->getMock();
+    $config->expects($this->any())
+      ->method('get')
+      ->will($this->returnValueMap($value_map));
+
+    $config_factory = $this->getMockBuilder('Drupal\Core\Config\ConfigFactory')
+      ->disableOriginalConstructor()
+      ->getMock();
+    $config_factory->expects($this->any())
+      ->method('get')
+      ->with('views.settings')
+      ->will($this->returnValue($config));

This looks like it could be replaced with $this->getConfigFactoryStub().

olli++ seriously, great catch!

Wonderful!

Seems like this is pretty self-contained, so should be safe to commit.

Committed and pushed to 8.x. Thanks!

I guess this doesn't need a change notice if it's internal to views?