Remove views_cache_get/set functions [#2140051]

Updated: Comment #N

Problem/Motivation

We still have views_cache_get and views_cache_set functions in views.module. This is only used on displayPluginBase class, once each.

Proposed resolution

Move any logic we need to into displayPluginBase::initDisplay. Remove the mentioned methods above.

Remaining tasks

Do it.

User interface changes

None.

API changes

None really, no one really has uses for views cache methods. This is something that was internal to views.

Comment	File	Size	Author
#5	interdiff-2140051-5.txt	2.86 KB	damiankloip
#5	2140051-5.patch	5.81 KB	damiankloip
#5
#2	interdiff-2140051-2.txt	1.86 KB	damiankloip
#2	2140051-2.patch	6.24 KB	damiankloip
#2
	vdc.remove-views-cache-functions.patch	4.38 KB	damiankloip

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 November 2013 at 17:32

Status:

Needs review

» Needs work

The last submitted patch, vdc.remove-views-cache-functions.patch, failed testing.

Comment #2

damiankloip CreditAttribution: damiankloip commented 20 November 2013 at 17:55

Status:

Needs work

» Needs review

File	Size
2140051-2.patch	6.24 KB

interdiff-2140051-2.txt	1.86 KB

1 file was hidden/shown/deleted

File	Size
vdc.remove-views-cache-functions.patch	4.38 KB

That unit test needs adapting.

Comment #3

dawehner

German

CreditAttribution: dawehner commented 20 November 2013 at 19:14

Nice work!

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
@@ -148,23 +153,23 @@ public function initDisplay(ViewExecutable $view, array &$display, array &$optio
-    static $unpack_options = array();
...
+        static::$unpackOptions[$cid] = $this->options;
...
+        $this->options = static::$unpackOptions[$cid];

It feels wrong to still have static functions but I agree that this is out of scope here.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
@@ -148,23 +153,23 @@ public function initDisplay(ViewExecutable $view, array &$display, array &$optio
+      $cid = 'unpackOptions:' . hash('sha256', serialize(array($this->options, $options))) . ':' . language(Language::TYPE_INTERFACE)->id;

You can also use the languageManager service as alternative to this function call.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
@@ -148,23 +153,23 @@ public function initDisplay(ViewExecutable $view, array &$display, array &$optio
+        $cache = cache('views_info')->get($cid);
...
+          cache('views_info')->set($cid, $this->options);

Can we replace that with \Drupal::cache() right now?

Comment #4

olli CreditAttribution: olli commented 20 November 2013 at 19:59

+++ b/core/modules/views/tests/Drupal/views/Tests/Plugin/display/PathPluginBaseTest.php
@@ -67,18 +67,41 @@ protected function setUp() {
+    $value_map = array(
+      array('skip_cache', TRUE),
+      array('display_extenders', array()),
+    );
+
+    $config = $this->getMockBuilder('Drupal\Core\Config\Config')
+      ->disableOriginalConstructor()
+      ->getMock();
+    $config->expects($this->any())
+      ->method('get')
+      ->will($this->returnValueMap($value_map));
+
+    $config_factory = $this->getMockBuilder('Drupal\Core\Config\ConfigFactory')
+      ->disableOriginalConstructor()
+      ->getMock();
+    $config_factory->expects($this->any())
+      ->method('get')
+      ->with('views.settings')
+      ->will($this->returnValue($config));

This looks like it could be replaced with $this->getConfigFactoryStub().