Updated: Comment #0

Problem/Motivation

#2135787: Move static config entity local tasks to local_tasks.yml added new-style local tasks for the view/form mode edit routes. The corresponding entries in hook_menu() were not removed however.

Proposed resolution

Remove the dead code from entity_menu().

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 2139195-1.patch1.05 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
FileSize
2139195-1.patch1.05 KB

Here we go.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks trivial, these are already in the local tasks file.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +Novice, +MenuSystemRevamp, +WSCCI novice, +WSCCI

tagging. we should keep our eye out for issues like these. if we can explain them well in an issues summary, they are great for novices. (especially like if a sprint like Vienna is coming up). Tagging novice anyway incase it needs a reroll or something. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Good catch!

Committed and pushed to 8.x. Thanks!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Note: Many of those menu entries are actually "required" because the corresponding route entries don't have a _title yet,
but the 1to1 conversion is for sure possible.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.