Updated: Comment #0

Problem/Motivation

ContentLanguageSettingsForm is supposed to display the page at admin/config/regional/content-language. It does not, in fact, do that. Instead language.routing.yml declares a _controller (not a _form!), which internally calls language_content_settings_form().

When used, it is in fact broken, due to

  • wrong entity_get_bundles() usage
  • a non-existent library being referenced

The form was introduced in #1978916: Convert locale_translate_page to a Controller.

Proposed resolution

Change language.routing.yml to use _form. Remove language_content_settings_form(). Fix ContentLanguageSettingsForm.

But for a call to entity_get_bundles() (which is modernized here) it's already up to core standards, so no further changes are contained.

Remaining tasks

API changes

language_content_settings_form() is removed.

CommentFileSizeAuthor
#1 2138151-1.patch8.19 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
8.19 KB

Here we go.

Status: Needs review » Needs work

The last submitted patch, 1: 2138151-1.patch, failed testing.

tim.plunkett’s picture