Problem/Motivation

There are several issues around MAINTAINERS.txt and CHANGELOG.txt vs. multilingual. For example, language module has no listed maintainers (the module is not even listed) and the new configuration translation module is not in CHANGELOG.txt.

Proposed resolution

- Figure out what other errors are there.
- Fix them.
- Commit.

Files: 
CommentFileSizeAuthor
#5 interdiff.txt1.18 KBGábor Hojtsy
#5 d8mi-txt-cleanup-v2.patch4.1 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 58,834 pass(es). View
#1 d8mi-txt-cleanup.patch4.08 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 58,765 pass(es). View

Comments

Gábor Hojtsy’s picture

Status: Active » Needs review
FileSize
4.08 KB
PASSED: [[SimpleTest]]: [MySQL] 58,765 pass(es). View

So found the following problems:

CHANGELOG:
- no mention of new field translation module (heh)
- no mention of old module removed
- no mention of config translation
- no mention of some developments like menu item language assignment, geenral entity language config
- no mention of configuration languages (eg. views, menu, etc)
- no mention of config schema
- no mention of context support in much of the menu system

MAINTAINERS.txt:

- language system is relatively up to date: plach and sun (not sure sun is considered an active maintainer, but see no reason to remove)
- title casing to fix in config translation
- translation module => content translation module
- locale => interface translation (locale) module
- language module was missing (added plach and myself based on activity / language system info)
- initiatives has me listed as well, which looks fine

xjm’s picture

Issue tags: +Component maintainers
+++ b/core/CHANGELOG.txt
@@ -77,15 +77,23 @@ Drupal 8.0, xxxx-xx-xx (development version)
-      * Made it possible to assign language to taxonomy terms, vocabularies
-        and files.
...
+      * Made it possible to assign language to taxonomy terms, vocabularies,
+        menu items and files.

@@ -97,10 +105,12 @@ Drupal 8.0, xxxx-xx-xx (development version)
+        Drupal.formatPlural() and routing, tabs, actions and contextual links.

Technically this should have the serial (Oxford) comma after "menu items" and "actions" per our documentation standards. Reference: https://drupal.org/style-guide/content
(I realize the comma wasn't there before either.)

I guess we also just need confirmation from plach on this issue that he wants to comaintain these components?

Gábor Hojtsy’s picture

Yeah I asked him to confirm. He is only added in one place, the other one is moved. And if we do not add language module, he will be assumed anyway via being under language system :)

plach’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

Gábor Hojtsy’s picture

FileSize
4.1 KB
PASSED: [[SimpleTest]]: [MySQL] 58,834 pass(es). View
1.18 KB

Let's fix those commas too :) That combined with your RTCB should make this fine :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Gábor Hojtsy’s picture

Yay, thanks!

Gábor Hojtsy’s picture

Issue tags: -sprint

Removing sprint tag too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.