Problem/Motivation
There are several issues around MAINTAINERS.txt and CHANGELOG.txt vs. multilingual. For example, language module has no listed maintainers (the module is not even listed) and the new configuration translation module is not in CHANGELOG.txt.
Proposed resolution
- Figure out what other errors are there.
- Fix them.
- Commit.
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff.txt | 1.18 KB | Gábor Hojtsy |
#5 | d8mi-txt-cleanup-v2.patch | 4.1 KB | Gábor Hojtsy |
#1 | d8mi-txt-cleanup.patch | 4.08 KB | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsySo found the following problems:
CHANGELOG:
- no mention of new field translation module (heh)
- no mention of old module removed
- no mention of config translation
- no mention of some developments like menu item language assignment, geenral entity language config
- no mention of configuration languages (eg. views, menu, etc)
- no mention of config schema
- no mention of context support in much of the menu system
MAINTAINERS.txt:
- language system is relatively up to date: plach and sun (not sure sun is considered an active maintainer, but see no reason to remove)
- title casing to fix in config translation
- translation module => content translation module
- locale => interface translation (locale) module
- language module was missing (added plach and myself based on activity / language system info)
- initiatives has me listed as well, which looks fine
Comment #2
xjmTechnically this should have the serial (Oxford) comma after "menu items" and "actions" per our documentation standards. Reference: https://drupal.org/style-guide/content
(I realize the comma wasn't there before either.)
I guess we also just need confirmation from plach on this issue that he wants to comaintain these components?
Comment #3
Gábor HojtsyYeah I asked him to confirm. He is only added in one place, the other one is moved. And if we do not add language module, he will be assumed anyway via being under language system :)
Comment #4
plachLooks good!
Comment #5
Gábor HojtsyLet's fix those commas too :) That combined with your RTCB should make this fine :)
Comment #6
webchickCommitted and pushed to 8.x. Thanks!
Comment #7
Gábor HojtsyYay, thanks!
Comment #8
Gábor HojtsyRemoving sprint tag too.