Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Introduce a way to avoid running a queue on cron time.
i.e. in drupal.org webheads does not have access to git, so if a queued versioncontrol sync job is processed during hook_cron, it will fail.
Note: this is already a feature in D8. See commit d9135600c92ecd7d747a386cf612c092e2d3e943
Proposed resolution
To add a new option on the queue array.
Remaining tasks
Patch for D8 and D7.
User interface changes
None.
API changes
A new configuration option, by default opt-in, so current behavior is kept.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2136369-4.patch | 1.5 KB | marvil07 |
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedD7 version, NR for bot.
Comment #2
marvil07 CreditAttribution: marvil07 commentedMinor bug in last patch fixed.
D8 is not needed, in D8 queue will be run only if queue defines it. So yep, that feature is already in D8!
Comment #3
sdboyer CreditAttribution: sdboyer commentedi think i'd just make a nit over the key name -
'skip on cron'
instead of'skip cron run'
. other than that, i'm prepared to RTBC.Comment #4
marvil07 CreditAttribution: marvil07 commentedThanks for the review.
Here the key name changed.
Comment #5
sdboyer CreditAttribution: sdboyer commentedgreat. RTBC.
Comment #6
marvil07 CreditAttribution: marvil07 commentedAdding a tag to let other drupal.org maintainers to know about this.
Comment #7
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x (with a small fix to the code comment on commit) - thanks! http://drupalcode.org/project/drupal.git/commit/e868ee8
So I guess this requires a small update to the existing Drupal 8 change notification at https://drupal.org/node/1537256?
Comment #8
marvil07 CreditAttribution: marvil07 commented@David_Rothstein: thanks for adding this to D7!
I have made an addition on the change notice to reflect the change. Let me know if there is anything else.
Comment #9
David_Rothstein CreditAttribution: David_Rothstein commentedLooks great, thanks! I just edited it to change the wording a tiny bit (because this is a Drupal 8 change notice, not a Drupal 7 one, so we should still only emphasize the changes that people upgrading from Drupal 7 to Drupal 8 will encounter). But all good now...
Comment #11
Berdir