Follow-up [meta] local task conversion, move out of hook_menu() and to local_tasks.yml [#2135777]

Updated: Comment #N

Problem/Motivation

#2102125: Big Local Task Conversion converted a bunch of local tasks.
#2111823: Convert field_ui / Entity local tasks to YAML definitions is doing node and field_ui

config translation noticed missing tab root ids as part of #2135101: Expand test coverage on configuration translation tabs

Proposed resolution

Convert the remaining.

Sub Issues

config entities: #2135787: Move static config entity local tasks to local_tasks.yml
#2109937: Manage fields local tasks not displayed at admin/config/people/accounts
field_ui and node: #2111823: Convert field_ui / Entity local tasks to YAML definitions
add more

Remaining tasks

Make sub issues.
add tips for reviewers, detailing how to review each sub issue

User interface changes

API changes

Comments

Comment #1

YesCT CreditAttribution: YesCT commented 14 November 2013 at 13:14

Maybe we ignore the test ones though for now?

634 $ ag "'type' => MENU_DEFAULT_LOCAL_TASK," core

core/modules/comment/comment.module
218:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/contact/contact.module
72:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/content_translation/content_translation.module
185:        'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/entity/entity.module
44:    'type' => MENU_DEFAULT_LOCAL_TASK,
70:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/field_ui/field_ui.module
87:        'type' => MENU_DEFAULT_LOCAL_TASK,
126:        'type' => MENU_DEFAULT_LOCAL_TASK,
130:        'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/filter/filter.module
141:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/image/image.module
101:    'type' => MENU_DEFAULT_LOCAL_TASK,
110:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/menu/menu.module
75:    'type' => MENU_DEFAULT_LOCAL_TASK,
91:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/node/node.module
940:    'type' => MENU_DEFAULT_LOCAL_TASK,
950:    'type' => MENU_DEFAULT_LOCAL_TASK,
960:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/path/path.module
67:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/picture/picture.module
68:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/shortcut/shortcut.module
101:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/simpletest/simpletest.module
43:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/system/tests/modules/batch_test/batch_test.module
21:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/system/tests/modules/menu_test/menu_test.module
109:    'type' => MENU_DEFAULT_LOCAL_TASK,
123:    'type' => MENU_DEFAULT_LOCAL_TASK,
144:    'type' => MENU_DEFAULT_LOCAL_TASK,
166:    'type' => MENU_DEFAULT_LOCAL_TASK,
176:    'type' => MENU_DEFAULT_LOCAL_TASK,
186:    'type' => MENU_DEFAULT_LOCAL_TASK,
267:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/taxonomy/taxonomy.module
245:    'type' => MENU_DEFAULT_LOCAL_TASK,
273:    'type' => MENU_DEFAULT_LOCAL_TASK,

core/modules/user/user.module
775:    'type' => MENU_DEFAULT_LOCAL_TASK,
791:    'type' => MENU_DEFAULT_LOCAL_TASK,

Comment #2

YesCT CreditAttribution: YesCT commented 14 November 2013 at 13:29

Title:	Follow-up (default) local task conversion, move out of hook_menu() and to local_tasks.yml	» Follow-up [meta] local task conversion, move out of hook_menu() and to local_tasks.yml
Issue summary:	View changes

let's split this up.
one config entity one: #2135787: Move static config entity local tasks to local_tasks.yml
and then make other sub issues for each of the rest of the modules?