Files affected:

votingapi/API.txt:95:  while ($result = db_fetch_array($results)) {
votingapi/votingapi.api.php:47:  while ($aggregate = db_fetch_array($aggregates)) {

See:
https://drupal.org/node/224333#dbtng

CommentFileSizeAuthor
#6 votingapi-depreciated-database-API-2135093-6-D7.patch1.91 KBsachinwable
#3 votingapi-depreciated-database-API-2135093-2-D7.patch1.81 KBsachinwable
#1 votingapi-depreciated-database-API-2135093-1-D7.patch1.81 KBsachinwable

Comments

sachinwable’s picture

sachinwable commented
Status: Active » Needs review
StatusFileSize
new votingapi-depreciated-database-API-2135093-1-D7.patch1.81 KB

Depreciated database APIs are fixed for D7

Status: Needs review » Needs work

The last submitted patch, 1: votingapi-depreciated-database-API-2135093-1-D7.patch, failed testing.

sachinwable’s picture

sachinwable commented
Status: Needs work » Needs review
StatusFileSize
new votingapi-depreciated-database-API-2135093-2-D7.patch1.81 KB

Fixed syntax error.

sachinwable’s picture

sachinwable commented
Assigned: Unassigned » sachinwable
rteijeiro’s picture

rteijeiro commented
Version: 7.x-2.11 » 7.x-3.x-dev
Component: Documentation » Code
Assigned: sachinwable » Unassigned
Category: Bug report » Task
Status: Needs review » Needs work

I would not consider it as a bug as it's not breaking anything. I think the patch should be sent against the latest codebase so changed the version to 7.x-3.x.

Also I suggest you to setup your git configuration correctly to create cleaner patches: https://www.drupal.org/documentation/git/configure

sachinwable’s picture

sachinwable commented
Status: Needs work » Needs review
StatusFileSize
new votingapi-depreciated-database-API-2135093-6-D7.patch1.91 KB
pifagor’s picture

pifagor commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed 283c1c8 on 7.x-2.x authored by sachinwable 
    Issue #2135093 by sachinwable, pifagor, kenorb, rteijeiro: Depreciated...
pifagor’s picture

pifagor commented
Version: 7.x-3.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.