Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Lots of small coding standards changes like:
- apply
{@inheritdoc}where it's not yet being used - s/
function/public function/ where that is not yet set - conform to 80 col rule
In other words: fix lots of small nitpicks that have been accumulated over time.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | drupal_2134909_5.patch | 16.33 KB | Xano |
| #1 | editor_nitpicks-2134909-1.patch | 18.12 KB | Wim Leers |
Comments
Comment #1
Wim LeersComment #2
jessebeach CreditAttribution: jessebeach commentedThere are three types of changes in this patch: (1) comment updates, (2) whitespace adjustment and (3) the introduction of
publicto test class methods.The patch applies cleanly and as long as testbot is happy, there's nothing dangerous or behavior-breaking in this patch.
Comment #3
Xano1: editor_nitpicks-2134909-1.patch queued for re-testing.
Comment #5
XanoRe-roll. The comment changes to
\Drupal\editor\Plugin\InPlaceEditor\Editorhad been committed elsewhere already.Comment #6
Wim LeersI compared the patches by hand, and they're indeed identical, minus the changes to
\Drupal\editor\Plugin\InPlaceEditor\Editor, which indeed have already been committed. So #5 introduces no changes: back to RTBC then! :)Comment #7
webchickCommitted and pushed to 8.x. Thanks!
Comment #8
Wim Leers