Lots of small coding standards changes like:

  1. apply {@inheritdoc} where it's not yet being used
  2. s/function/public function/ where that is not yet set
  3. conform to 80 col rule

In other words: fix lots of small nitpicks that have been accumulated over time.

CommentFileSizeAuthor
#5 drupal_2134909_5.patch16.33 KBxano
#1 editor_nitpicks-2134909-1.patch18.12 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new editor_nitpicks-2134909-1.patch18.12 KB
jessebeach’s picture

jessebeach commented
Status: Needs review » Reviewed & tested by the community

There are three types of changes in this patch: (1) comment updates, (2) whitespace adjustment and (3) the introduction of public to test class methods.

The patch applies cleanly and as long as testbot is happy, there's nothing dangerous or behavior-breaking in this patch.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

1: editor_nitpicks-2134909-1.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: editor_nitpicks-2134909-1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_2134909_5.patch16.33 KB

Re-roll. The comment changes to \Drupal\editor\Plugin\InPlaceEditor\Editor had been committed elsewhere already.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

I compared the patches by hand, and they're indeed identical, minus the changes to \Drupal\editor\Plugin\InPlaceEditor\Editor, which indeed have already been committed. So #5 introduces no changes: back to RTBC then! :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.