hass noted in #2120021: RTL: Disk down button has wrong horizontal position that the position of the disclosure disks of menus in the Toolbar tray in RTL text direction is a little off. It turns out that the padding is not being properly reset because of an overriding style with [dir="rtl"] in the selector.
Seen here in LTR
and here in RTL
This is a one line fix. Patch to be posted
It'll look a little nicer in RTL languages.
None.
#2120021: RTL: Disk down button has wrong horizontal position
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | toolbar-css-disk-rtl-2131897-1.patch | 863 bytes | jessebeach |
| #1 | Welcome_to_Drupal_D8_Dev___Drupal_D8_Dev.png | 45.93 KB | jessebeach |
| #1 | Welcome_to_Drupal_D8_Dev___Drupal_D8_Dev-3.png | 49.96 KB | jessebeach |
Comments
Comment #1
jessebeach commentedComment #2
jessebeach commentedComment #3
jessebeach commentedRemove padding from the disk button in RTL languages.
Comment #4
wim leersManually tested and verified the CSS cascade by looking at developer tools. This indeed fixes the problem correctly.
Comment #5
webchickI'm going to give this one the "Scariest sounding issue title to fewest lines of code in its patch" award. :D (I did not know what a disclosure disk was and it sounded like a hardware problem. :D)
Committed and pushed to 8.x. Thanks!
Comment #6
wim leersHaha :D Thank you!