Task to convert MimeTypeMatcherTest to phpunit. See #1938068: Convert UnitTestBase to PHPUnit.

CommentFileSizeAuthor
#6 mimetypematcher-phpunit-2130551-06.patch9.76 KBjhedstrom
#6 interdiff.txt3.75 KBjhedstrom
#3 system-mimetypematcher-phpunit-2130551-03.patch6.28 KBjhedstrom
#3 interdiff.txt1.13 KBjhedstrom
#1 system-mimetypematcher-phpunit-2130551-01.patch5.14 KBjhedstrom

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new system-mimetypematcher-phpunit-2130551-01.patch5.14 KB

Here's an initial attempt.

Status: Needs review » Needs work

The last submitted patch, 1: system-mimetypematcher-phpunit-2130551-01.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.13 KB
new system-mimetypematcher-phpunit-2130551-03.patch6.28 KB

This fixes the fatals in simpletest caused by moving the RoutingFixtures class.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue tags: +PHPUnit

Tagging.

dawehner’s picture

dawehner
Primary language German
commented

Is there a reason why we do not let testFilterRoutes just use a dataProvider? The three code hunks look really similar.

Otherwise this looks perfect.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new interdiff.txt3.75 KB
new mimetypematcher-phpunit-2130551-06.patch9.76 KB

This moves to using a dataProvider. I also added groups.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.