Field translation test is still use the old field_name property

This is correct but I have no idea why it didn't fail previously so I am assigning this to yched in hope he has some insight. That should not block committing this.

Indeed, nice catch. Test classes that have seen addition after addition are sorry stacks of crappy code...

Refactored/cleaned a bit more, but reverted the unrelated entity_get_info() / field_info_instances() changes, I'm not in favor of doing those bit by bit in unrelated issues.

+++ b/core/modules/field/lib/Drupal/field/Tests/TranslationTest.php
@@ -137,9 +131,12 @@ function testFieldAvailableLanguages() {
     $this->assertTrue(count($available_langcodes) == 1 && $available_langcodes[0] === Language::LANGCODE_NOT_SPECIFIED, 'For untranslatable fields only Language::LANGCODE_NOT_SPECIFIED is available.');

Is that right? "For untranslatable fields only Language::LANGCODE_NOT_SPECIFIED is available." I thought things could know their language even if they were not translatable.
.

tagging d8mi as it is related to translation

+++ b/core/modules/field/lib/Drupal/field/Tests/TranslationTest.php
@@ -149,7 +152,7 @@ function testFieldAvailableLanguages() {
-    $entity_info = entity_get_info('node');
+    $entity_info = \Drupal::entityManager()->getDefinition('node');

@@ -257,7 +260,7 @@ function testFieldDisplayLanguage() {
-    $instances = field_info_instances($entity_type, $bundle);
+    $instances = \Drupal\field\Field::fieldInfo()->getBundleInstances($entity_type, $bundle);

it makes sense to not do these changes bit by bit. but which issue is doing them? let's link to it.

4: field_translation_test-2125497-4.patch queued for re-testing.

Reroll

@YesCT

"For untranslatable fields only Language::LANGCODE_NOT_SPECIFIED is available." I thought things could know their language even if they were not translatable

Yes, in the new Entity/Field API, but this is still testing the "old" field_language_*() API, that behaves a little differently. This API is being deprecated, but there are still a couple blocker issues, for now it's still here along with the corresponding tests.

The patch didn't apply anymore, so I re-rolled it.

14: 2125497-14.patch queued for re-testing.

Back to RTBC...

No longer applies, presumably because we just removed the old translation API.

One more time! :)

Heh :-)

In the end, there's actually not much left to fix here now, the faulty test has been removed along with the old translation API.
What's left from the patch are just minor streamline / cleanups with no functional impact.

Reuploading it, and setting back to RTBC (since what's left has been RTBCed before), but this doesn't really match the issue title & category anymore.

22: field-trans-old-field-name-2125497-22.patch queued for re-testing.

Random test fail.

Committed and pushed to 8.x. Thanks!