Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
filter.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Nov 2013 at 13:14 UTC
Updated:
29 Jul 2014 at 23:06 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerComment #2
eric_a commentedYes, contrib maintainers should not have to deal with this kind of a plugin type API inconsistency. In fact, shouldn't this be a beta blocker?
Is there a meta for plugin usage and other usage?
Comment #3
eric_a commentedComment #5
eric_a commentedRerolled.
The context has changed a little after #2105959: Make sure all YML files in Filter module has no type-casting to string..
Currently contrib filter maintainers cannot leave out the provider annotation and they can't fix their plugins by putting in the key either...
Comment #7
eric_a commentedComment #8
berdirShould be $this->provider, no?
Core maintainers decide what's a beta blocker, so reverting tag.
Comment #9
eric_a commentedChanged that.
Comment #11
berdirSo that was actually hiding remaining usage of $filterplugin->module...
Comment #12
eric_a commentedFixed
FilterBag::sortHelper().Comment #13
berdirNice, I think this is good to go then.
Comment #14
webchickCommitted and pushed to 8.x. Thanks!
Let's get a change notice about this.
Comment #15
berdirThe user-facing part here is very small (there is no reason to use/access the provider/module, updated https://drupal.org/node/2015901 to remove the module in the example annotation. It also won't break anything if the module key is left there, so no need for a new change notice for this IMHO.
Comment #17
eric_a commentedI've created #2196977: Drupal/filter/Annotation/Filter uses public $module instead of $provider.