It's great that we have the save_draft module in place as it provides an improved content authoring experience. However, only Administrators can actually use this by default. I think the default permissions need to be updated to enable Editors to use this also since they are the ones that will be creating/editing content.

CommentFileSizeAuthor
#1 panopoly_admin-2124727-save-draft-for-editors.patch481 bytesmrfelton

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new panopoly_admin-2124727-save-draft-for-editors.patch481 bytes
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me! Thanks. :-)

mrfelton’s picture

mrfelton commented
Status: Reviewed & tested by the community » Fixed

Committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mrfelton’s picture

mrfelton commented
Status: Closed (fixed) » Active

Somehow, this is not in the latest codebase

jdearie’s picture

jdearie commented

Editor role still does not have permission by default in fresh install of Panopoly 7.x-1.6

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

It's in the code base: http://cgit.drupalcode.org/panopoly_admin/tree/panopoly_admin.features.d...

However @jdearie is correct that the permission isn't being set on install.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Version: 7.x-1.0-rc5 » 7.x-1.x-dev
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

It's probably a dependency/order thing... panopoly_admin doesn't actually depend on save_draft (because we want it to be optional), but it defines a permission that is declared by save_draft. So, probably it's trying to set the permission before save_draft is installed. We could add the perm in a hook_modules_installed() after 'save_draft' is installed instead?

  • mrfelton committed e5e86fd on 8.x-1.x 
    Updting Panopoly Admin for #2124727 - Editors unable to save draft...

  • mrfelton committed e5e86fd on 8.x-2.x 
    Updting Panopoly Admin for #2124727 - Editors unable to save draft...

  • 2d5e37b committed on 7.x-1.x 
    #2124727 - Editors unable to save draft content by default
  • 04340c1 committed on 7.x-1.x
    Issue #2124727: Editors unable to save draft content by default