Closed (fixed)
Project:
Commerce Kickstart
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Oct 2013 at 09:24 UTC
Updated:
14 May 2015 at 09:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bojanz commentedThis is probably too big of a change to happen in Kickstart 2.x at this point.
The features 2.x update isn't really a smooth ride for some people (because of the field + field instance separation) and we'd need to figure out how to reroll
our performance patches and custom calls (in the feature install files) that we needed to done in order to make Kickstart install properly with a bunch of features.
That means we need days of resources which we don't have at this point.
Comment #2
bojanz commentedThis might be possible now.
Lars has been adding Behat tests, and has time to test manually as well.
I've converted the Features patches and custom calls, then re-exported the features.
The PR is up at and will need very careful testing :https://github.com/commerceguys/commerce_kickstart/pull/18
Comment #3
rootworkWould love to see this. There's a bug in Features 1.x related to PHP 5.4: #1588596: Notice: Array to string conversion in features_export_prepare() (line 190 of features.export.inc). It's been fixed in 2.x.
Comment #4
sebastien m. commentedI'm too interested by features 2.x.
Can you update this ticket ?
Comment #5
lsolesen commented@Sebastien You are welcome to finish @bojanz work :) And help testing the current changes.
Comment #6
lsolesen commentedLatest code is here: https://github.com/lsolesen/commerce_kickstart/tree/features2x-2229673
Comment #7
chrisolofAs someone who cringes when config isn't held in code I'd love to see Kickstart move to features 2.x. The 1.x interface is a real pain in comparison.
Looks like this pull request might do it?
https://github.com/commerceguys/commerce_kickstart/pull/74
Comment #8
lsolesen commented@chrisolof There is still a couple of hickups with the pull request. If you have time to fix those, we would love to get it committed.
Comment #9
jantoine commentedBelow are instructions for creating a patch against the latest release. I have attached a patch for 7.x-2.21.
git clone --branch 7.x-2.x http://git.drupal.org/project/commerce_kickstart.git
cd commerce_kickstart
git remote add lsolesen https://github.com/lsolesen/commerce_kickstart.git
git fetch lsolesen
git checkout -b 7.x-2.21 7.x-2.21
scripts/build.sh 7.x-2.21
rm -fr 7.x-2.21/profiles/commerce_kickstart/.git
mv 7.x-2.21 ../
cd ../7.x-2.21
git init
git add -A
git commit -m "- Initial commit."
cd ../commerce_kickstart/
git checkout -b features2-image-field lsolesen/features2-image-field
git rebase --onto 7.x-2.21 7.x-2.x features2-image-field
scripts/build.sh 7.x-2.21-features2
rm -fr 7.x-2.21-features2/profiles/commerce_kickstart/.git
mv 7.x-2.21-features2 ../
cp -r ../7.x-2.21-features2/. ../7.x-2.21
cd ../7.x-2.21
git add -A
git diff --cached > ../commerce-kickstart-features2.patch
remove all hunks for .info files where the only thing that changed was the timestamp
Comment #10
candelas commentedHello
Does it works with Commerce Kickstart 2.22? Thanks
Comment #11
candelas commentedI add this errors that I get in a fresh 2.22 install on features.
Comment #12
bojanz commentedMerged in https://github.com/commerceguys/commerce_kickstart/pull/105.
Thank you, lsolesen and mglaman!