Can we do this now? I think we 'broke' the menu router old, and nothing in core uses this now.

Let's see what happens anyway.

CommentFileSizeAuthor
#6 2122019-6.patch2.33 KBdamiankloip
#6 interdiff-2122019-6.txt652 bytesdamiankloip
d8-remove-getMenuItem.patch2.4 KBdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented

+1 thought I fear that there are a few like update_manager_install_form() which live in a .manager.inc file and so potentially break.

damiankloip’s picture

damiankloip commented

Well, all those forms now have wrappers that load the required files first. So I think this is ok?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah it is.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

+1

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs review 
+++ b/core/lib/Drupal/Core/Form/FormBuilder.php
@@ -475,21 +475,7 @@ public function submitForm($form_arg, &$form_state) {
     $form_state['build_info']['form_id'] = $form_id;
...
+    $form_state['build_info']['form_id'] = $form_id;

Why the same assignment statement twice?

damiankloip’s picture

damiankloip commented
StatusFileSize
new interdiff-2122019-6.txt652 bytes
new 2122019-6.patch2.33 KB

hmm, good question!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

6: 2122019-6.patch queued for re-testing.

dries’s picture

dries commented

Looks like a nice little clean-up. It appears both #0 and #6 need to be applied on top of one another. Just want to double check before going ahead. Please confirm. Thank you!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Nope #6 is required only. The difference between #0 and #6 is just removing the duplicate line.

 $form_state['build_info']['form_id'] = $form_id;
-    $form_state['build_info']['form_id'] = $form_id;
dries’s picture

dries commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Oops, you're right. I was accidentally looking at the interdiff. Committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.