Updated: Comment #0

Problem/Motivation

+++ b/core/lib/Drupal/Core/Form/FormBuilder.php
@@ -0,0 +1,1770 @@
+      array_shift($args);
+      array_shift($args);

Proposed resolution

A simple doc line would be great here.

Remaining tasks

Do it.

User interface changes

None

API changes

None

Follow-up from #2112807-32: Move the form builder functions in form.inc to a form service. 5. (see also comment #33)

CommentFileSizeAuthor
#1 form-2120863-1.patch782 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
form-2120863-1.patch782 bytes

Let's actual improve this to match what we do in other sections of core.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Awesome.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

1: form-2120863-1.patch queued for re-testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

1: form-2120863-1.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Lovely!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.