Updated: Comment 0

Problem/Motivation

Adding more test coverage.

Proposed resolution

Remaining tasks

User interface changes

API changes

Comments

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new4.39 KB

.

The last submitted patch, vdc-2120589-1.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

#1: vdc-2120589-1.patch queued for re-testing.

jibran’s picture

1: vdc-2120589-1.patch queued for re-testing.

jibran’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

more test++

jibran’s picture

Status: Reviewed & tested by the community » Needs work

Some minor issues other then that it is RTBC.

  1. +++ b/core/modules/views/tests/Drupal/views/Tests/Controller/ViewAjaxControllerTest.php
    @@ -133,10 +133,88 @@ public function testAjaxView() {
    +    $display_handler = $this->getMockBuilder('Drupal\views\Plugin\views\display\DisplayPluginBase')
    ...
    +    $display_bag = $this->getMockBuilder('\Drupal\views\DisplayBag')
    ...
    +    $display_handler = $this->getMockBuilder('Drupal\views\Plugin\views\display\DisplayPluginBase')
    ...
    +    $display_bag = $this->getMockBuilder('\Drupal\views\DisplayBag')
    

    I think standard is not to use \ at start.

  2. +++ b/core/modules/views/tests/Drupal/views/Tests/Controller/ViewAjaxControllerTest.php
    @@ -170,6 +248,32 @@ protected function setupValidMocks() {
    +  protected function getCommands(ViewAjaxResponse $response) {
    

    function missing description line.

  3. +++ b/core/modules/views/tests/Drupal/views/Tests/Controller/ViewAjaxControllerTest.php
    @@ -170,6 +248,32 @@ protected function setupValidMocks() {
    +   * Ensure that the main view content command is added.
    

    Ensures

dawehner’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new4.55 KB
new2.04 KB

Thank you!

jibran’s picture

Thanks for the fixes @dawehner. RTBC +1.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yay moar tests!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.