Now fields can only be attached to a single entity type, \Drupal\field\FieldInterface::getBundles() no longer needs to be a nested array, as it will only return the bundles for a single entity type anyway.

CommentFileSizeAuthor
#3 2119471-3.patch586 bytesamateescu
#2 2119471-2.patch1.39 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

swentel CreditAttribution: swentel commented

I think it's only the comment that needs to be updated, it now only returns an array of bundles iirc.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
Issue tags: +Field API
FileSize
2119471-2.patch1.39 KB

I think this should be fine

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -DX (Developer Experience), -Field API
FileSize
2119471-3.patch586 bytes

I believe you meant this, and yes, it's the documentation that we need to fix here.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2119471-3.patch, failed testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Needs review

3: 2119471-3.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Reviewed & tested by the community

Back to RTBC then ?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.