The "Add subscriptions" page subscriptions/add/node/nnn appears not to respect the settings I have made in the "Visibility of controls" section of my preferences. I have set the send interval to hidden and the "Send updates" and "Send comments" to visible but the "Add subscriptions" page still shows the "Send interval" menu but not the "Updates" and "Comments" controls.

Comments

salvis’s picture

Category: bug » task
Status: Active » Postponed (maintainer needs more info)

Yes, right now it's hard-wired to only show the Send Interval. I couldn't make up my mind on how it should work, and I'm looking for comments...

Keep in mind that these links are primarily intended to be used from an external context, e.g. like http://drupal.org/node/206525#comment-697333, and they're only there because I didn't find a better place for them.

gustav’s picture

I think it would be good if that "Add subscription" page respected the same options as the subscription fieldset.

I would remove the links from the subscription fieldset to the "Add subscription" link because, as you said, they don't serve any purpose there. It would probably be good enough to mention their existence in the documentation so that people who have a use for them know about them.

salvis’s picture

The "Add subscription" link? Have you already found it? What exactly are you referring to?

I was wondering whether those links serve only the admin (then documentation would be good enough) or whether users have a use for them, too, e.g. to send subscribe links to their buddies.

gustav’s picture

Sorry, where I wrote "Add subscription link" I meant "Add subscription page".

I was indeed thinking that those links would only be made available by the site admin. I can't really see any other use for them.

gustav’s picture

Status: Postponed (maintainer needs more info) » Active

What I think would really be most useful would be to have an "Add subscription" page that contains ALL the controls of the subscription fieldset that is currently shown on node pages. I think it should simply look identical to that expanded fieldset.

This will make those people happy who, because it fits better into their theme, would like to replace the subscription fieldset by a link.

salvis’s picture

Status: Active » Postponed (maintainer needs more info)

Please open a new issue for #5 — it doesn't belong here.

I'd like to see some other opinions on the original issue here.

gustav’s picture

On the original issue, I believe that the users would expect the choices they made in their settings to apply to the "Add subscription" pages in the same way as to the Subscription fieldsets.

#5 already has a workaround patch at http://drupal.org/node/208631

salvis’s picture

Version: 5.x-2.0-beta9 » 5.x-2.0-beta11
Status: Postponed (maintainer needs more info) » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.