Remove the Drupal.checkWidthBreakpoint method from drupal.js; replace with window.matchMedia where appropriate

oh yes please, never got around to getting rid of it.

( edit ) and guess which module we had to introduce it for initially? Overlay :þ

Drupal.checkWidthBreakpoint is marked as @deprecated, but doesn't specify a version for removal.

At this point in the release cycle for PHP code we'd say D9.0.0, but I'm not sure about JS.

Hi,

It appears that Drupal 8 is supposed to support IE9, according to https://www.drupal.org/node/61509 , and it doesn't look like matchMedia is supported by IE9 according to http://caniuse.com/#feat=matchmedia. I haven't personally used the deprecated Drupal.checkWidthBreakpoint method, but I suggest if it is an alternative for window.matchMedia that we wait until at least D9.

@jesse.voogt

we have matchmedia polyfill in core.

The attached patch replaces all occurences of the Drupal.checkWidthBreakpoint method with window.matchMedia. To look for files where it's being used you can use the following grep command:

$ grep -iRl "Drupal.checkWidthBreakpoint" .
./core/misc/drupal.js
./core/misc/vertical-tabs.js
./core/modules/ckeditor/js/ckeditor.js

The patch doesn't remove yet the Drupal.checkWidthBreakpoint function definition from ./core/misc/drupal.js as it's marked as deprecated.

You can remove the function from drupal.js, it doesn't exist in D7 so it was to make sure people didn't start using it in D8.

for vertical tabs the backbone folks are ok with us copying the responsive vtabs they got so it'll go away eventually.

@nod_ ok, thanks for your feedback. The new patch removes Drupal.checkWidthBreakpoint entirely from core. Regarding vertical tabs, I'm not aware about those changes. Can you point me in the right direction if there's anything more that should be done related to this issue?

This works fine, vtabs still work as expected. Hope it makes it, wouldn't want to ship D8 with new-already-deprecated APIs.

@nod_ failed tests doesn't seem related to the patch itself. Is this a normal behavior? Should we queue it for re-testing and update the status every time this happens?

Probably some testbot snafu.

This is a JS-only patch so testbot has nothing to say that's relevant here.

I set it back to "Needs work" anyway, it would need to patch core.libraries.yml and add matchmedia polyfill as dependencies

@nod_, @droplet thanks for helping out!

Oops, core/misc/drupal.js doesn't require the matchmedia dependency.

Good call :) forgot that it was even a polyfill.

Old browsers…

Needs a reroll :(

on it.

looks green enough

How green is green enough for a JS patch?

Given the low number of usages, the odd functionality and the fact it has been deprecated for ages... Committed c8f4690 and pushed to 8.0.x. Thanks!

Woohoo! We made it! This is my first contribution to Drupal core and I really enjoyed it, thanks everyone! :D