When activating the taxonomy term view and browsing to a category in the default commerce kickstart theme there is no term title / H1. In the attached image you'll see the tabs and the start of the product listings but no title....

CommentFileSizeAuthor
#8 missing_h1_title_on-2118059-8.patch2.96 KBmglaman
#7 missing_h1_title_on-2118059-7.patch3 KBmglaman
#6 missing_h1_title_on-2118059-6.patch1.7 KBmglaman
Screen Shot 2013-10-22 at 21.58.30.png257.3 KBvaccinemedia

Comments

Poieo’s picture

Poieo commented
Issue summary: View changes

Took me awhile to find this...

Commerce Kickstart Block module hides the page title on the front page and on taxonomy term pages with the following:

/**
 * Implements hook_preprocess_page().
 */
function commerce_kickstart_block_preprocess_page(&$variables) {
  if (drupal_is_front_page()) {
    // Remove the title from this page.
    $variables['title'] = '';
  }
  if (arg(0) == 'taxonomy' && arg(1) == 'term' && is_numeric(arg(2))) {
    // Remove collection_taxonomy_term view title.
    $variables['title'] = '';
 }
}

To get your titles back you must disable the module.

vaccinemedia’s picture

vaccinemedia commented

Well found! I solved the issue by disabling title across the board in the theme settings and using delta blocks to create a block for the page title and displaying it where I wanted to from there. Good to know how to treat the cause rather than the symptom though in future! However, now I'm getting used to Omega 4..... Shame there isn't a good commerce kickstart theme (for the full functionality / modules of kickstart) based on this ;)

lsolesen’s picture

lsolesen commented

Seems to be a duplicate of #1953738: $title variable is empty

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Version: 7.x-2.9 » 7.x-2.x-dev
Category: Support request » Bug report
Issue tags: +sprint

Marking as a bug, because commerce_kickstart_taxonomy should be hiding the title from the page, not the block module to prevent unexpected issues like this.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue tags: +Novice
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new missing_h1_title_on-2118059-6.patch1.7 KB

Moved logic from commerce_kickstart_block to commerce_kickstart_taxonomy, and logic performs more checks to only affect vocabulary provided by distribution.

Build: https://travis-ci.org/commerceguys/commerce_kickstart/builds/71785636.

If the actual issue is the ability to toggle this logic on or off, then it needs to be stated. Otherwise the change in this patch will be committed, and that functionality opened as a new issue.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new missing_h1_title_on-2118059-7.patch3 KB

Updated with tests. Build: https://travis-ci.org/commerceguys/commerce_kickstart/builds/72018266

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new missing_h1_title_on-2118059-8.patch2.96 KB

Turns out this was never working because the current_path for taxonomy was collection/% or product_category/% :) So it was just breaking all other taxonomy/term/% pages.

New patch, new build: https://travis-ci.org/commerceguys/commerce_kickstart/builds/72108925

  • mglaman committed 0b7b211 on 7.x-2.x 
    Issue #2118059: Missing H1 / Title on default taxonomy view
  • mglaman committed 44b7cec on 7.x-2.x
    Merge pull request #133 from mglaman/2118059-missing-title-on-taxonomy-...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alexp999’s picture

alexp999 commented

This has caused me a bit of a headache this morning, new issue started:
https://www.drupal.org/node/2566869