My Wysiwyg Linebreaks module was working as of 8.x-alpha3—when a user visited admin/config/content/formats/manage/basic_html with a standard profile install, the user would see a 'Conversion Method' configuration form in the 'CKEditor plugin settings' area, regardless of what buttons were enabled.
Now, however, the Conversion Method form/vertical tab is always hidden, no matter what the value returned by isEnabled() (the markup is present, but it is set to display:none). The only way to get the configuration form to display is to add a button (which is really annoying, because it would have to be a non-functional 'dummy' button).

I was under the impression that CKEditorPluginContextualInterface::isEnabled was supposed to allow plugins to display configuration forms with or without buttons, and indeed, that was the case up until sometime in the past couple of months.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | ckeditor_plugin_hiding-2117687-3.patch | 910 bytes | wim leers |
| #2 | ckeditor-admin-form-fix.2117687-2.patch | 1.31 KB | geerlingguy |
| conversion-method-missing.png | 45.99 KB | geerlingguy |
Comments
Comment #1
geerlingguy commentedIn my debugging, it looks like CKEditorPluginManager::getEnabledPluginFiles() is working correctly, at least—setting isEnabled() to TRUE and isInternal() to FALSE correctly adds linebreaks to the $additional_plugins array returned by getEnabledPluginFiles().
Still looking...
Comment #2
geerlingguy commentedAttached patch fixes this problem—the CKEditor admin JS was not checking whether a settings form was for a button or not.
Comment #3
wim leersDarn — sorry :( I broke this in #2089631: Showing/hiding of CKEditor plugin settings is fragile, automate it (breaks in narrow viewports and when enabling CKEditor), which actually makes things a lot better for most CKEditor plugins out there, but clearly the code is not specific enough. (I really wish we had JS tests!)
However, I think the solution can be even simpler than your patch :)
Thanks for the report and patch!
Comment #4
geerlingguy commentedYep - this looks perfect to me! (Pre-emptively set to RTBC—the tests will pass).
Comment #5
wim leersGreat :)
Comment #6
wim leers3: ckeditor_plugin_hiding-2117687-3.patch queued for re-testing.
Comment #7
webchickCommitted and pushed to 8.x. Thanks!
Comment #8
wim leersComment #9
nod_