Problem/Motivation
Since #1914070: Improve version fallback for install language. at least Drupal 8 will download alpha2 translations properly. Even if Drupal 8 alpha5 is out. (Then once a beta1 is out, that will be the new base for translation downloads and then rc1, but even if rc3 is out).
Proposed resolution
Ideally we'd have a server side version fallback system where if we ask for 8.x-dev downloads, it would *redirect* us to the latest version downloads (so we know the version downloaded from the file name and can track).
1. Work out the server side solution in #2113957: Build server side version fallback system for translations
2. Remove fallback logic from core as necessary and rely on server side fallback. Remove tests for fallback logic.
Remaining tasks
Commit.
User interface changes
None.
API changes
None.
Related Issues
#1914070: Improve version fallback for install language.
#2113957: Build server side version fallback system for translations
#2555021: Create branch symlink to latest translation
Comment | File | Size | Author |
---|---|---|---|
#20 | Screen Shot 2015-09-09 at 2.40.04 PM.png | 174.17 KB | webchick |
#20 | Screen Shot 2015-09-09 at 2.39.26 PM.png | 127.05 KB | webchick |
#10 | interdiff-2113955-7-10.txt | 5.61 KB | Sutharsan |
#10 | rely_on_proper_server-2113955-10.patch | 12.64 KB | Sutharsan |
#7 | rely_on_proper_server-2113955-7.patch | 7.24 KB | japerry |
Comments
Comment #0.0
Gábor HojtsyUpdate with server side issue link.
Comment #1
catchNot sure why this is tagged with revisit, there's nothing controversial here?
Comment #2
Gábor Hojtsy@catch: all right, then opened #2285795: Drupal 8 loads alpha2 translations instead of alpha12 in light of https://localize.drupal.org/node/6433.
Comment #3
Gábor HojtsyPostponing on #2113957: Build server side version fallback system for translations
Comment #4
basic CreditAttribution: basic at Drupal Association commentedComment #5
basic CreditAttribution: basic at Drupal Association commentedEdit: moving this from #2555021: Create branch symlink to latest translation
I've added the following rewrites to nginx:
I've manually created a single symlink for drupal, and views, to use as tests:
Comment #6
japerryresetting to active because #2113957: Build server side version fallback system for translations is done. That will pretty much gut most of the work done in #1914070: Improve version fallback for install language. and replace it with either the release or dev version of drupal8.
Comment #7
japerryHere is a first crack at fixing this issue, based on the changes we've made on the localization server. I have a feeling that _install_prepare_import() could use some cleanup, but is only sorta related to this issue.
Comment #9
Gábor HojtsyChanges look good to me. Also less code to maintain, yay :) Looks like the only fail is in InstallerTranslationVersionUnitTest which makes sense given we would not do the translation fallback on the client anymore.
Comment #10
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedRemoving the unit test of
install_get_localization_release()
. This function was removed in #7.Comment #11
Gábor HojtsyGo testbot!
Comment #12
Gábor HojtsyNeeds manual testing given that we cannot do automated testing of this, it relies on configuration of the server side. Looks good in code review. Also less code to maintain and update yay!
Comment #13
Gábor HojtsyTweeted here too asking for manual testing https://twitter.com/gaborhojtsy/status/641265982816821248
Comment #14
Gábor HojtsyI manually tested this applying to both 8.x-dev and 8.0.0-beta15 and both worked. From then on its up to the server side to work right and send the right file. While that is still refined in #2113957: Build server side version fallback system for translations we can get on with this as far as I see. Thanks @japerry, @Sutharsan!
Comment #15
Gábor HojtsyComment #17
Gábor HojtsyMigrateTermNodeTest did not complete fail does not sound related.
Comment #19
Gábor HojtsyComment #20
webchickThat is lovely. :)
I tested this two ways, one with my wifi turned on and one with it turned off.
With it turned on:
With it turned off:
That error message needs some work, both grammar-wise ("requires to contact" => "requires contacting") and SafeMarkup-wise (the link HTML is shown as escaped plain text). However, that's not part of this patch so we can fix it in a normal follow-up.
Committed and pushed to 8.0.x. YEAH! :D
Comment #21
webchickComment #23
Gábor HojtsyYay, thanks!