global $conf;
    if (isset($conf['php_storage'][$name])) {
      $configuration = $conf['php_storage'][$name];
    }
    elseif (isset($conf['php_storage']['default'])) {
      $configuration = $conf['php_storage']['default'];
    }
CommentFileSizeAuthor
#2 core-phpstorage-conf-to-settings-2113621-2.patch2.91 KBParisLiakos

Comments

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Critical

Since $conf doesn't exist except as an override this actually critical :/

ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new core-phpstorage-conf-to-settings-2113621-2.patch2.91 KB

this should do it

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I never set this to CNR, but since you posted exactly the same patch as me (without realising?), I think I'm allowed to RTBC it.

ParisLiakos’s picture

ParisLiakos commented

i cant see a patch posted by you..unless, you mean the fact that now all patches appear in OP, got you:P
new d.o is confusing;)

catch’s picture

catch
he/him
Primary language English
commented

Wow no wonder the two patches were exactly the same then...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.