Rename \Drupal\Core\Config\Entity\ConfigEntityInterface::getOriginalID() to \Drupal\Core\Config\Entity\ConfigEntityInterface::getOriginalId() and setOriginalID() to setOriginalId(). This change is consistent with our coding standards.

CommentFileSizeAuthor
#11 drupal_2113319_11.patch14.06 KBxano
#7 drupal_2113319_6.patch13.34 KBxano
#3 drupal_2113319_3.patch13.31 KBxano
#1 drupal_2113319_1.patch13.31 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal_2113319_1.patch13.31 KB

Status: Needs review » Needs work

The last submitted patch, drupal_2113319_1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_2113319_3.patch13.31 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Config/Entity/ConfigStorageController.php
@@ -432,7 +432,7 @@ public function save(EntityInterface $entity) {
-      $entity->setOriginalID($entity->id());
+      $entity->setOriginalId$entity->id());

This (also everywhere else) is missing the "(" part.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: Unassigned » xano
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Assigned: xano » Unassigned

Oops that was a crosspost, I meant the first patch.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_2113319_6.patch13.34 KB

Speaking of crossposts ;)

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

I'm not seeing any function definitions in the patch?!

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

The method names were apparently fixed a while ago, but some erroneous usages remained.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

I found another instance in line 36 of \Drupal\views_ui\Tests\ViewUIObjectTest

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_2113319_11.patch14.06 KB

Ah, an array key. That's why PHPStorm did not find it.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Awesome, let's do it.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

#11: drupal_2113319_11.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal_2113319_11.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

#11: drupal_2113319_11.patch queued for re-testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

11: drupal_2113319_11.patch queued for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

11: drupal_2113319_11.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Since PHP functions aren't case-sensitive, I don't believe this needs a change notice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.