Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2111209: Rename FormInterface::getFormID() to FormInterface::getFormId()
We are renaming the function to get it consistent with our coding standards.
Beta phase evaluation
Issue category | Task because the current naming is not consistent with our coding standards. |
---|---|
Disruption | There is no disruption because php method names are case insensitive. It is only for our coding standards. |
It is allowed because there is no disruption.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2113243-9.patch | 4.69 KB | rpayanm |
Comments
Comment #1
tstoecklerBtw, does anyone agree with me that the thing should actually be called BaseFormInterface instead of BaseFormIdInterface? I think I'll open a follow-up for that.
Comment #2
tstoecklerPhpStorm++
Comment #3
XanoLooks good! I found one more occurrence.
Comment #4
tstoecklerHuh, PhpStorm--
Comment #5
jhedstromComment #6
rpayanmNiet! PHPStorm++
Comment #7
daffie CreditAttribution: daffie commentedIt all looks good to me.
You only missed one in the file core/modules/config_translation/src/Form/ConfigTranslationFormBase.php .
Comment #8
rpayanm@daffie thank you!
Comment #9
rpayanmupss wrong patch
Comment #10
daffie CreditAttribution: daffie commentedAll instances of BaseFormIdInterface::getBaseFormID() are renamed to BaseFormInterface::getBaseFormId().
The patch looks good, so I give it RTBC.
Comment #13
tstoecklerComment #14
alexpottSo this issue says it is renaming BaseFormIdInterface::getBaseFormID() to BaseFormInterface::getBaseFormId() - it does not actually rename the interface - only the method - well it fixes the capitalisation. I don't think that BaseFormIdInterface should become BaseFormInterface since FormBase and ConfigFormBase do not implement it - the interface is solely about provided a base ID - so I think it well named.
This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.
Comment #15
daffie CreditAttribution: daffie commentedBack to RTBC, because the patch does what the new title is saying and the beta phase evaluation is added.
@alexpott: Sorry for missing the renaming of the interface in the title. :-(
Comment #16
daffie CreditAttribution: daffie commentedComment #17
alexpottComment #18
alexpottCommitted 2e6efcb and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.