Wrong redirection in admin/modules/uninstall/confirm if drupal is installed in a subdirectory

Are you sure, because that is in the confirm buildForm method, not in the submit. None the less, that path is wrong indeed.

I think URLs should now be generated from route names.

A quick grep for use of this class shows code like this:

  public function redirect($route_name, array $route_parameters = array(), $status = 302) {
    $url = $this->urlGenerator()->generate($route_name, $route_parameters, TRUE);
    return new RedirectResponse($url, $status);
  }

Ran into the same problem just now, the attached patch seems to be the right way to fix it.

@swentel: I don't understand it either, the code doesn't look like it, but this is definitely where the problem is coming from. And without the patch, uninstalling also didn't work (at least for me, though that might have been a fluke).

I think it should be

// Prevent this page from showing when the module list is empty.
if (empty($this->modules)) {
  return $this->redirect('system.modules_uninstall');
}

as is done in ModulesListConfirmForm::buildForm()

Added test and update IS

Update IS

+++ b/core/modules/system/src/Tests/Module/UninstallTest.php
@@ -106,5 +106,10 @@ function testUninstallPage() {
+
+    // Make sure confirmation page is accessible only during uninstall process.
+    $this->drupalGet('admin/modules/uninstall/confirm');
+    $this->assertUrl('admin/modules/uninstall');
+    $this->assertTitle(t('Uninstall') . ' | Drupal');

That doesn't seem related to me.

That doesn't seem related to me.

why do you think is not related? we should test that, by accessing directly to the confirm page, you will be redirected properly

Ah ok fair enough. That's a property of confirm forms I wasn't aware of.

This can be RTBC now #5 works, just tested by creating sub directory and moving site into that directory. Downloaded token 8.x and installed then uninstalled and returns user to modules page

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 487de77 and pushed to 8.0.x. Thanks!