Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The block plugins already made this switch and it should be redundant.
Comment | File | Size | Author |
---|---|---|---|
#13 | 2112705-interdiff.txt | 1.03 KB | mikey_p |
#13 | 2112705-entity-type-provider-13.patch | 33.28 KB | mikey_p |
#11 | 2112705-11.patch | 32.18 KB | swentel |
#7 | 2112705-7.patch | 32.91 KB | swentel |
#7 | interdiff.txt | 1.31 KB | swentel |
Comments
Comment #1
swentel CreditAttribution: swentel commentedtwo patches - one with a fallback - one without.
Comment #2
mikey_p CreditAttribution: mikey_p commented#1: 2112705-1.patch queued for re-testing.
Comment #4
BerdirYay!
I'm fine with dropping this without a fallback.
We also need to remove the documentation of this in Annotation/EntityType
Comment #5
swentel CreditAttribution: swentel commentedShould fix dozens of exceptions
Comment #7
swentel CreditAttribution: swentel commentedMight be green
Comment #8
dawehnerI could not find any other entity beside bideo which still uses the module key on the annotation.
Comment #9
mikey_p CreditAttribution: mikey_p commentedThanks for fixing this. Little things like this add up to improve DX!
Comment #10
alexpottPatch no longer applies.
Comment #11
swentel CreditAttribution: swentel commentedComment #12
alexpottThe module key is still used in
config_get_module_config_entities()
but this function is unused so I think this patch should remove it - as it is untested, unneeded and with this change, broken.Comment #13
mikey_p CreditAttribution: mikey_p commentedComment #14
BerdirNice find!
Tried what I could to find any other left-over references but couldn't find anything. Back to RTBC.
Comment #15
alexpottCommitted bf3e9cf and pushed to 8.x. Thanks!