The block plugins already made this switch and it should be redundant.

Files: 
CommentFileSizeAuthor
#13 2112705-interdiff.txt1.03 KBmikey_p
#13 2112705-entity-type-provider-13.patch33.28 KBmikey_p
PASSED: [[SimpleTest]]: [MySQL] 59,422 pass(es).
[ View ]
#11 2112705-11.patch32.18 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 59,628 pass(es).
[ View ]
#7 2112705-7.patch32.91 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 59,567 pass(es).
[ View ]
#7 interdiff.txt1.31 KBswentel
#5 2112705-5.patch31.91 KBswentel
FAILED: [[SimpleTest]]: [MySQL] 59,471 pass(es), 3 fail(s), and 6,905 exception(s).
[ View ]
#5 interdiff.txt2.01 KBswentel
#1 2112705-1.patch31.19 KBswentel
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#1 2112705-1-no-fallback.patch29.9 KBswentel
FAILED: [[SimpleTest]]: [MySQL] 59,309 pass(es), 5 fail(s), and 16,832 exception(s).
[ View ]

Comments

swentel’s picture

Status:Active» Needs review
StatusFileSize
new29.9 KB
FAILED: [[SimpleTest]]: [MySQL] 59,309 pass(es), 5 fail(s), and 16,832 exception(s).
[ View ]
new31.19 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

two patches - one with a fallback - one without.

mikey_p’s picture

#1: 2112705-1.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, 2112705-1-no-fallback.patch, failed testing.

Berdir’s picture

Yay!

I'm fine with dropping this without a fallback.

We also need to remove the documentation of this in Annotation/EntityType

swentel’s picture

Status:Needs work» Needs review
StatusFileSize
new2.01 KB
new31.91 KB
FAILED: [[SimpleTest]]: [MySQL] 59,471 pass(es), 3 fail(s), and 6,905 exception(s).
[ View ]

Should fix dozens of exceptions

Status:Needs review» Needs work

The last submitted patch, 2112705-5.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review
StatusFileSize
new1.31 KB
new32.91 KB
PASSED: [[SimpleTest]]: [MySQL] 59,567 pass(es).
[ View ]

Might be green

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

I could not find any other entity beside bideo which still uses the module key on the annotation.

mikey_p’s picture

Thanks for fixing this. Little things like this add up to improve DX!

alexpott’s picture

Status:Reviewed & tested by the community» Needs work
Issue tags:+Needs reroll

Patch no longer applies.

swentel’s picture

Status:Needs work» Reviewed & tested by the community
Issue tags:-Needs reroll
StatusFileSize
new32.18 KB
PASSED: [[SimpleTest]]: [MySQL] 59,628 pass(es).
[ View ]
alexpott’s picture

Issue summary:View changes
Status:Reviewed & tested by the community» Needs work

The module key is still used in config_get_module_config_entities() but this function is unused so I think this patch should remove it - as it is untested, unneeded and with this change, broken.

mikey_p’s picture

Status:Needs work» Needs review
StatusFileSize
new33.28 KB
PASSED: [[SimpleTest]]: [MySQL] 59,422 pass(es).
[ View ]
new1.03 KB
Berdir’s picture

Status:Needs review» Reviewed & tested by the community
Parent issue:» #2095603: [meta] Complete Entity Field API

Nice find!

Tried what I could to find any other left-over references but couldn't find anything. Back to RTBC.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed bf3e9cf and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.