Follow-up from #2112569: [meta] Convert non-controller forms to FormInterface.

CommentFileSizeAuthor
#5 interdiff.txt784 bytestim.plunkett
#5 dblog-2112675-5.patch11.19 KBtim.plunkett
#3 dblog-2112675-3.patch12.1 KBtim.plunkett
#3 interdiff.txt1.65 KBtim.plunkett
#2 dblog-2112675-2.patch11.16 KBtim.plunkett
#2 interdiff.txt2.98 KBtim.plunkett
#1 dblog-2112675-1.patch9.5 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new dblog-2112675-1.patch9.5 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue summary: View changes
StatusFileSize
new interdiff.txt2.98 KB
new dblog-2112675-2.patch11.16 KB

Rerolled.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new interdiff.txt1.65 KB
new dblog-2112675-3.patch12.1 KB

Rerolled.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

This would get simpler after #2145007: Convert form_set_error() in FormBase classes to use FormErrorInterface

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dblog-2112675-5.patch11.19 KB
new interdiff.txt784 bytes

That went in.

The last submitted patch, 5: dblog-2112675-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

5: dblog-2112675-5.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

The last submitted patch, 5: dblog-2112675-5.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.