Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
taxonomy.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
17 Jan 2008 at 09:09 UTC
Updated:
3 Nov 2022 at 19:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
webchickYep, I can confirm this bug, and that the patch fixes it.
I'm going to be a stickler here though, since that is the Drupal way, and this way you learn good practices, since I know you're new to core patching. :)
a) When you roll patches, please do so from the Drupal root directory (the one with INSTALL.txt, etc. in it). That makes it easier for people to apply them.
b) Please use
cvs diff -up > blah.patchto roll your patches. The -up provides much more human-readable output, and also indicates which function is being affected.c)
You're missing a space before this line, so that it lines up with the one below (told you I was going to be a stickler ;))
d) About this code:
- That's an awful lot of stuff to do on one line. :)
- You're doing a taxonomy_get_term here, then throwing away the result, then immediately on the next line doing one again. While the terms are cached, if you already have the value once, why not re-use it? I'd maybe move the !empty check around the $output variable instead.
Comment #2
Anonymous (not verified) commentedImproved version of above patch, taking into account webchick's comments.
Comment #3
webchickCool! This is just about there, but remember to adhere to our Coding Standards. Specifically:
Incidentally, there's this rad module called Coder that can do these sort of coding standards checks for you automatically. Nice to run just before you upload a patch to make sure you didn't miss anything. :)
Comment #4
Anonymous (not verified) commentedChanges to adhere to Coding Standards.
Comment #5
webchickTested, working, can't find anything else wrong. :) Marking RTBC.
Comment #6
webchickAhem.
Comment #7
gábor hojtsyLooks good and logical, thanks, committed.
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.