Replace user_access() through injected user accounts in views.

Rerolled, plus don't believe all of those failures.

reroll + small nitpicks.
also, I didn't see the errors locally too.

EDIT: tests also pass on simplytest.me (including this patch).

I guess you are running this in the UI only? If you run this from the command line, you should see these failures (I think).

reroll.
if this comes back with less fails, then I'd say this helped: #2073531: Use current user service instead of _account, remove _account from the request object (see #32, #37.1)

16: 2109433-16.patch queued for re-testing.

well, it has come down to this error:

PHP Fatal error: Call to a member function setDisplay() on a non-object in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/views/lib/Drupal/views/Routing/ViewPageController.php on line 72

and its stack trace in the drupal code is:

Drupal\views\Routing\ViewPageController->handle() /var/www/menu-links/core/modules/views/tests/Drupal/views/Tests/Routing/ViewPageControllerTest.php:99

I hope this helps others to fix it.

1. +++ b/core/modules/views/lib/Drupal/views/Tests/ViewExecutableTest.php
   @@ -361,8 +361,9 @@ public function testDestroy() {
   +    unset($defaults['user']);
   

   Nice

2. +++ b/core/modules/views/lib/Drupal/views/ViewExecutable.php
   @@ -418,11 +426,14 @@ class ViewExecutable {
   +  public function __construct(ViewStorageInterface $storage, AccountInterface $user) {
   ...
   +    $this->user = $user;
   

   We are calling this account when it's passed to access checks but user here. I think it should be called account everywhere? Just putting this out there. If there's a reason for this. Let me have it.

Access checks just need any account, but in most cases the account we pass on is the current user, which is more than just an account.

$ grep -lr user_access * | grep "Plugin/views"

core/modules/node/lib/Drupal/node/Plugin/views/filter/Access.php
core/modules/user/lib/Drupal/user/Plugin/views/access/Permission.php
core/modules/user/lib/Drupal/user/Plugin/views/access/Role.php
core/modules/user/lib/Drupal/user/Plugin/views/field/Language.php
core/modules/user/lib/Drupal/user/Plugin/views/field/User.php

replacing cases mentioned in #24.

25: vdc-2109433-25.patch queued for re-testing.

this should pass. the docblock on the getUser() function probably needs review though. I'm bad at writing :D

just a note (that might be unrelated here) that the previous failing test in Drupal\user\Tests\Views\HandlerFilterUserNameTest is a bit fragile.
I became curious when the test was failing on 2 of 3 identical asserts in a loop. turned out the test is checking for simple numbers (2, 3, 4), which might be already present on the page, from the test header, etc.
the test might have passed just as well. and actually, it did pass locally for me, because I had error reporting on, and stack traces do contain a lot of numbers.
so, is this a separate issue? works as designed? should be fixed here? or else?

adding #30.

oops. patch was uploaded with wrong extension.

another case to use the injected $user in ViewExecutable.

reroll.

including #35.

Committed and pushed to 8.x. Thanks!