AttributeTest fails when using debian's phpunit binary [#2108643]

Comment	File	Size	Author
#3	drupal-phpunit-debian-2108643-3.patch	1.24 KB	ParisLiakos

Comment #1

ParisLiakos CreditAttribution: ParisLiakos commented 9 October 2013 at 22:17

Issue tags:

+PHP 5.5

this is the last test after the json one, for our phpunit test suite to be green under php 5.5

Log in or register to post comments

Comment #2

ParisLiakos CreditAttribution: ParisLiakos commented 9 October 2013 at 22:28

Priority:

Major

» Normal

nvm..this is a phpunit thing..seems the debian package is quite outdated
this was fixed...2 years ago upstream!

if you run tests using the vendor binary it still works..

i still think we should fix the test to work with the debian binary version, the fix is pretty simple i think

Log in or register to post comments

Comment #3

ParisLiakos CreditAttribution: ParisLiakos commented 9 October 2013 at 22:33

Title:	AttributeTest fails under php 5.5	» AttributeTest fails when using debian's phpunit binary
Issue tags:	-PHP 5.5

File	Size
drupal-phpunit-debian-2108643-3.patch	1.24 KB

here is whats missing from debian's version of phpunit, that causes this test to fail:
https://github.com/sebastianbergmann/phpunit/commit/f48cb8ba2903b2da3a63...

and here is a patch that adds some contents in the div, rather than being empty

Log in or register to post comments

Comment #4

ParisLiakos CreditAttribution: ParisLiakos commented 9 October 2013 at 22:33

Status:

Active

» Needs review

Log in or register to post comments

Comment #5

dawehner

German

CreditAttribution: dawehner commented 14 October 2013 at 13:25

Status:	Needs review	» Reviewed & tested by the community
Issue tags:		+PHPUnit

Even if it is not stricly needed I consider this as improvement!

Log in or register to post comments

Comment #6

Mile23

English

Seattle, WA

CreditAttribution: Mile23 commented 15 October 2013 at 02:05

+++ b/core/tests/Drupal/Tests/Core/Template/AttributeTest.php
@@ -92,12 +92,13 @@ public function testIterate() {
   public function testPrint() {
     $attribute = new Attribute(array('class' => array('example-class'), 'id' => 'example-id', 'enabled' => TRUE));
 
-    $html = '<div' . (string) $attribute . '></div>';
-    $this->assertSelectEquals('div.example-class', '', 1, $html);
-    $this->assertSelectEquals('div.example-class2', '', 0, $html);
+    $content = $this->randomName();
+    $html = '<div' . (string) $attribute . '>' . $content . '</div>';
+    $this->assertSelectEquals('div.example-class', $content, 1, $html);
+    $this->assertSelectEquals('div.example-class2', $content, 0, $html);

I hate to tell someone to change a test fundamentally, but that's really screaming out for a @dataprovider.