Comment translation overview has broken local tasks

Try comment.permalink instead of comment_permalink. Same for the others in that file.

All local tasks in comment.local_tasks.yml need to use the comment DOT notation, not underscores. I noted this in an unrelated issue and the fix got removed in that patch, since it still worked kind of with comment_menu() having those tabs also. This would be the cleanup for comment stuff AFAIS.

Rerolled for current head, less changes needed in local_tasks.yml, since the task names now use dots. The route names don't, so the tabs basically refer to nonexistent routes.

This is my idea to fix it.

This fixes nearly all of the tests.

Could it be that the entity_test_mul should have a label entity key in order to be translatable?

+++ b/core/modules/content_translation/lib/Drupal/content_translation/Tests/ContentTranslationUITest.php
@@ -99,6 +100,22 @@ protected function assertBasicTranslation() {
+      if ($entity->hasTranslation($langcode)) {
+        debug($entity->getTranslation($langcode)->label());
+        $this->assertText($entity->getTranslation($langcode)->label(), format_string('Label correctly shown for %language translation', array('%language' => $langcode)));

debug() is still in there...

#15: content_translation-2106349-15.patch queued for re-testing.

#2102125-19: Big Local Task Conversion related to the dot underscore naming for local tasks.

Updated issue summary.

The interdiff in #2106349-15: Comment translation overview has broken local tasks looks just perfect. I would love to RTBC that.

I read the patch.
titles and labels are matching, uses correct naming convention, removes local tasks from hook_menu that are in comment.local_tasks.yml or already in comment.routing.yml
weight of delete is different. trying manually: both before and after, delete is first in the list of links: " delete edit reply approve"
also, I dont see /view in the patched version. I'll try it manually. Both before and after the patch comment/1/view gives page not found, so ok.

this looks ok to me. rtbc.

replacing tag lost in cross post.

Updated issue summary.

1. +++ b/core/modules/content_translation/lib/Drupal/content_translation/Access/ContentTranslationOverviewAccess.php
   @@ -45,7 +45,8 @@ public function appliesTo() {
   -    if ($entity = $request->attributes->get('entity')) {
   +    $entity_type = $request->attributes->get('_entity_type');
   +    if ($entity = $request->attributes->get($entity_type)) {
          // Get entity base info.
          $entity_type = $entity->entityType();
          $bundle = $entity->bundle();
   

   Why do we get $entity_type from the request, then later get it again from $entity?

Why do we get $entity_type from the request, then later get it again from $entity?

There is no reason at all.

Removed the double usage of $entity_type.

Committed/pushed to 8.x, thanks!