Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

block.block.bartik.breadcrumbs.yml
block.block.bartik.content.yml
block.block.bartik.footer.yml
block.block.bartik.help.yml
block.block.bartik.login.yml
block.block.bartik.powered.yml
block.block.bartik.search.yml
block.block.bartik.tools.yml
block.block.seven.breadcrumbs.yml
block.block.seven.content.yml
block.block.seven.help.yml
block.block.seven.login.yml
editor.editor.basic_html.yml
editor.editor.full_html.yml
entity.display.node.article.default.yml
entity.display.node.article.teaser.yml
entity.form_display.node.article.default.yml
field.field.node.field_image.yml
field.field.node.field_tags.yml
field.instance.node.article.field_image.yml
field.instance.node.article.field_tags.yml
filter.format.basic_html.yml
filter.format.full_html.yml
filter.format.restricted_html.yml
node.type.article.yml
node.type.page.yml
rdf.mapping.comment.node__comment.yml
rdf.mapping.node.article.yml
rdf.mapping.node.page.yml
rdf.mapping.taxonomy_term.tags.yml
system.cron.yml
taxonomy.vocabulary.tags.yml
user.role.administrator.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#7 2106029-remove-string-casting-7.patch27.33 KBsivaji@knackforge.com
PASSED: [[SimpleTest]]: [MySQL] 59,582 pass(es).
[ View ]
#3 remove-string-casting-2106029.patch29.91 KBBarrett
PASSED: [[SimpleTest]]: [MySQL] 59,929 pass(es).
[ View ]

Comments

mtift’s picture

Issue tags:+Novice

Tagging

Barrett’s picture

Assigned:Unassigned» Barrett

I'll take this one.

Barrett’s picture

Status:Active» Needs review
StatusFileSize
new29.91 KB
PASSED: [[SimpleTest]]: [MySQL] 59,929 pass(es).
[ View ]
derheap’s picture

The Patch fails. Needs a Reroll.

derheap’s picture

Issue summary:View changes
Issue tags:+Needs reroll
derheap’s picture

Status:Needs review» Needs work
sivaji@knackforge.com’s picture

Status:Needs work» Needs review
StatusFileSize
new27.33 KB
PASSED: [[SimpleTest]]: [MySQL] 59,582 pass(es).
[ View ]

Patch rerolled.

@Barrett, sorry for interjecting. Lately realized that this issue is assigned to you.

vijaycs85’s picture

Status:Needs review» Needs work
  1. +++ b/core/profiles/standard/config/block.block.bartik_breadcrumbs.yml
    @@ -1,24 +1,24 @@
    +status: 0
    ...
    +  label_display: 0
    ...
    +    visibility: 0

    +++ b/core/profiles/standard/config/block.block.bartik_content.yml
    @@ -1,24 +1,24 @@
    +status: 1
    ...
    +  label_display: 0
    ...
    +    visibility: 0

    +++ b/core/profiles/standard/config/block.block.bartik_help.yml
    @@ -1,24 +1,24 @@
    +status: 1
    ...
    +  label_display: 0

    +++ b/core/profiles/standard/config/block.block.bartik_login.yml
    @@ -1,24 +1,24 @@
    +status: 1

    +++ b/core/profiles/standard/config/block.block.bartik_powered.yml
    @@ -1,24 +1,24 @@
    +status: 1

    +++ b/core/profiles/standard/config/block.block.bartik_search.yml
    @@ -1,8 +1,8 @@
    +status: 1

    @@ -10,15 +10,15 @@ settings:
    +    visibility: 0

    +++ b/core/profiles/standard/config/block.block.seven_breadcrumbs.yml
    @@ -1,24 +1,24 @@
    +status: 0
    ...
    +  label_display: 0
    ...
    +    visibility: 0

    +++ b/core/profiles/standard/config/block.block.seven_content.yml
    @@ -1,24 +1,24 @@
    +status: 1
    ...
    +  label_display: 0
    ...
    +    visibility: 0

    +++ b/core/profiles/standard/config/block.block.seven_help.yml
    @@ -1,24 +1,24 @@
    +  label_display: 0
    ...
    +    visibility: 0

    +++ b/core/profiles/standard/config/block.block.seven_login.yml
    @@ -1,25 +1,25 @@
    +    visibility: 0

    +++ b/core/profiles/standard/config/field.field.node.field_image.yml
    @@ -26,9 +26,9 @@ settings:
    +locked: 0
    ...
    +translatable: 0

    +++ b/core/profiles/standard/config/field.field.node.field_tags.yml
    @@ -4,15 +4,15 @@ name: field_tags
    +active: 1
    ...
    +locked: 0
    ...
    +translatable: 0
    ...
    so on...

    All boolean values should be true/false instead of 0/1.

  2. +++ b/core/profiles/standard/config/block.block.seven_help.yml
    @@ -1,24 +1,24 @@
    +  label: System Help

    +++ b/core/profiles/standard/config/block.block.seven_login.yml
    @@ -1,25 +1,25 @@
    +  label: User login

    +++ b/core/profiles/standard/config/field.instance.node.article.field_image.yml
    @@ -5,18 +5,18 @@ field_uuid: 748beaea-5074-4ff2-b51c-28a643d37c3a
    +  file_extensions: png gif jpg jpeg

    +++ b/core/profiles/standard/config/field.instance.node.article.field_tags.yml
    @@ -5,10 +5,10 @@ field_uuid: 60db47f4-54fb-4c86-a439-5769fbda4bd1
    +description: Enter a comma-separated list of words to describe your content.

    all multi-word strings should be in in single quotes. Seems most of them are correct at the moment.

sivaji@knackforge.com’s picture

@vijaycs85, thanks for the review. I will submit an updated patch if no response from Barrett.

vijaycs85’s picture

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.

vijaycs85’s picture

Status:Needs work» Closed (duplicate)