Follow-up from #1653026: [META] Use properly typed values in module configuration.
Problem/Motivation
All integers, Booleans, and even octal numbers in config object files are converted to strings.
Proposed resolution
#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.
Remaining tasks
block.block.bartik.breadcrumbs.yml
block.block.bartik.content.yml
block.block.bartik.footer.yml
block.block.bartik.help.yml
block.block.bartik.login.yml
block.block.bartik.powered.yml
block.block.bartik.search.yml
block.block.bartik.tools.yml
block.block.seven.breadcrumbs.yml
block.block.seven.content.yml
block.block.seven.help.yml
block.block.seven.login.yml
editor.editor.basic_html.yml
editor.editor.full_html.yml
entity.display.node.article.default.yml
entity.display.node.article.teaser.yml
entity.form_display.node.article.default.yml
field.field.node.field_image.yml
field.field.node.field_tags.yml
field.instance.node.article.field_image.yml
field.instance.node.article.field_tags.yml
filter.format.basic_html.yml
filter.format.full_html.yml
filter.format.restricted_html.yml
node.type.article.yml
node.type.page.yml
rdf.mapping.comment.node__comment.yml
rdf.mapping.node.article.yml
rdf.mapping.node.page.yml
rdf.mapping.taxonomy_term.tags.yml
system.cron.yml
taxonomy.vocabulary.tags.yml
user.role.administrator.yml
User interface changes
NO
API changes
NO
Related Issues
Parent: #1653026: [META] Use properly typed values in module configuration
Comment | File | Size | Author |
---|---|---|---|
#7 | 2106029-remove-string-casting-7.patch | 27.33 KB | Sivaji_Ganesh_Jojodae |
#3 | remove-string-casting-2106029.patch | 29.91 KB | Barrett |
Comments
Comment #1
mtiftTagging
Comment #2
Barrett CreditAttribution: Barrett commentedI'll take this one.
Comment #3
Barrett CreditAttribution: Barrett commentedComment #4
derheap CreditAttribution: derheap commentedThe Patch fails. Needs a Reroll.
Comment #5
derheap CreditAttribution: derheap commentedComment #6
derheap CreditAttribution: derheap commentedComment #7
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedPatch rerolled.
@Barrett, sorry for interjecting. Lately realized that this issue is assigned to you.
Comment #8
vijaycs85All boolean values should be true/false instead of 0/1.
all multi-word strings should be in in single quotes. Seems most of them are correct at the moment.
Comment #9
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commented@vijaycs85, thanks for the review. I will submit an updated patch if no response from Barrett.
Comment #10
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.
Comment #11
vijaycs85