Problem/Motivation
Configuration translation module just starts to use the new local task derivatives, and some core paths don't use named local tasks proper or name their local tasks improperly. The attached patch aims to fix these for the use cases where config translation fails to match up tabs with the core tabs due to the inconsistencies.
1. The maintenance tab in system tabs was improperly named, it should be $route_name . '_tab' for the default tab.
2. The user account settings tab is not defined with the local tasks .yml
3. The config test module is not converted to local tasks.yml and includes generally useless items in hook_menu anyway.
Proposed resolution
Fix those in the scope to let config translation properly work with these tabs in contrib with the *new way* [TM]. So far while these are not properly fixed, config translation needs to use the old way. #sadpanda
Remaining tasks
Review, commit.
User interface changes
None.
API changes
None.
Related Issues
#2095269: Remove add_edit_tab, core should have default tabs
Comment | File | Size | Author |
---|---|---|---|
#4 | fix-tabs-for-config-translation-core-4.patch | 2.73 KB | Gábor Hojtsy |
#4 | interdiff.txt | 519 bytes | Gábor Hojtsy |
#3 | fix-tabs-for-config-translation-core-3.patch | 2.76 KB | Gábor Hojtsy |
fix-tabs-for-config-translation-core.patch | 4.55 KB | Gábor Hojtsy | |
Comments
Comment #1
Gábor HojtsyComment #2
Gábor HojtsyMarking as blocker for #2095269: Remove add_edit_tab, core should have default tabs and consequently config_translation module in core.
Comment #3
Gábor Hojtsy@vijaycs85 pointed out the moving of title from hook_menu to route yml may be an issue with some edge case currently. Since those are not needed to fulfill this patch I removed them. I also forgot to add the config test local task yaml in the above patch, so now included. This is the absolute minimal set of changes needed to resolve this, get tabs up to speed on these places (and it will make config_translation pass green again on testbot :D).
Comment #4
Gábor HojtsyAand make sure to include newline at end of file :D
Comment #5
Gábor HojtsyComment #6
vijaycs85Thanks @Gábor Hojtsy. Changes looks good to me. RTBC, if testbot is happy.
Comment #8
tstoeckler#4: fix-tabs-for-config-translation-core-4.patch queued for re-testing.
Comment #9
Gábor HojtsyAs per above. Test issue was a bot fluke.
Comment #10
tstoecklerMakes total sense. Just to make this clear to committers: This patch fixes the currently failing tests in config_translation, because the local tabs due not appear currently where they should. Therefore this stops all progress in config_translation due to the branch failing. It would be awesome if this could go in soon.
Comment #11
Gábor HojtsyAdding one more tag to help committers find it :)
Comment #12
webchickThis looks good to me. It'll conflict with the patch floating out there somewhere that attempts to convert all local tasks at once, but I don't see it in the RTBC list atm so I think this is fine.
Committed and pushed to 8.x. Thanks!
Comment #13
YesCT CreditAttribution: YesCT commentedoh, this broke account settings: #2109937: Manage fields local tasks not displayed at admin/config/people/accounts