I have officially taken over from @jenlampton as the Twig/theme system "initiative" lead.

CommentFileSizeAuthor
#11 drupal-add-mark-carver-to-2103231-3.patch904 bytesmarkhalliwell
#3 drupal-add-mark-carver-to-2103231-3.patch904 bytesmarkhalliwell
#1 2103231-drupal-maintainers_theme_system_mark_carver-1.patch878 bytesmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Active » Needs review
FileSize
2103231-drupal-maintainers_theme_system_mark_carver-1.patch878 bytes

Attaching patch.

Status: Needs review » Needs work

The last submitted patch, 2103231-drupal-maintainers_theme_system_mark_carver-1.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Needs work » Needs review
FileSize
drupal-add-mark-carver-to-2103231-3.patch904 bytes

Trying with drush_iq instead...

Status: Needs review » Needs work

The last submitted patch, drupal-add-mark-carver-to-2103231-3.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Needs work » Needs review

#3: drupal-add-mark-carver-to-2103231-3.patch queued for re-testing.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

+1.

Not sure why testbot is hating on these patches.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Version: 7.x-dev » 8.x-dev

Dreditor clone button FTW..... sigh, I'm an id10t.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

Totally missed that. :)

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented

#1: 2103231-drupal-maintainers_theme_system_mark_carver-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-add-mark-carver-to-2103231-3.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Needs work » Needs review
FileSize
drupal-add-mark-carver-to-2103231-3.patch904 bytes

Submitting new patch against 8.x.... epic foo bar

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Needs review » Reviewed & tested by the community

Looks good to me (and green! yay!) :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 5d2de6c and pushed to 8.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Component maintainers

Automatically closed -- issue fixed for 2 weeks with no activity.