Subtask of #1830588: [META] remove drupal_set_title() and drupal_get_title()

Problem/Motivation

Using procedural drupal_set_title() inside controller class is not encouraged.

Proposed resolution

Replace drupal_set_title() with #title in page return array.

Remaining tasks

Issue patch

User interface changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

API changes

Refer parent issue at #1830588: [META] remove drupal_set_title() and drupal_get_title()

Files: 
CommentFileSizeAuthor
#11 drupal-remove-drupal_set_title-from-translation-2102445-11.patch1.52 KBwebwarrior
PASSED: [[SimpleTest]]: [MySQL] 60,034 pass(es).
[ View ]

Comments

vijaycs85’s picture

vijaycs85’s picture

Status:Active» Postponed
disasm’s picture

StatusFileSize
new978 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,777 pass(es).
[ View ]

this shouldn't conflict with the conversion. One line fix to get the remaining drupal_set_title removed.

cam8001’s picture

Status:Postponed» Needs review
dawehner’s picture

Issue summary:View changes
Status:Needs review» Reviewed & tested by the community

Perfect!

dawehner’s picture

Xano’s picture

vijaycs85’s picture

Issue summary:View changes
Status:Needs review» Reviewed & tested by the community

as per #5, back to RTBC.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

webwarrior’s picture

Status:Closed (fixed)» Needs review
StatusFileSize
new1.52 KB
PASSED: [[SimpleTest]]: [MySQL] 60,034 pass(es).
[ View ]

Removed the drupal_set_title from overview page.

Also now displays the more user friendly title. Don't know if there was a decision made to only display "Translate" as title for that page?

plach’s picture

Status:Needs review» Reviewed & tested by the community

Looks good, thanks

webchick’s picture

Status:Reviewed & tested by the community» Fixed

Not sure; looks like an oversight to me. Nice catch!

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.