Change Drupal\Core\Routing\RouteBuildEvent::getModule() to getProvider()

+1 on this in concept. Although I think the Dumper uses "route set" or something generic like that. We should probably use the same term there as well. (Either switch to "set" here, or "provider" there. I guess I'm OK with either.)

Just wondering whether it is worth to break other peoples code, if they use the actual RouteSubscriberInterface.

1. +++ b/core/lib/Drupal/Core/Routing/MatcherDumper.php
   @@ -77,8 +77,8 @@ public function addRoutes(RouteCollection $routes) {
   +   * - provider:  The route grouping that is being dumped. All existing
   

   I would be fine with having a little bet less spaces after the ":"

2. +++ b/core/lib/Drupal/Core/Routing/RouteSubscriberBase.php
   @@ -20,7 +20,7 @@
   -   * objects with $collection->add($route);.
   +   * objects with $collection->add('route_name', $route);.
   

   +2!

3. +++ b/core/modules/system/system.install
   @@ -2295,6 +2295,22 @@ function system_update_8060() {
    /**
   + * Rename the router table 'route_set' field to 'provider'.
   + */
   +function system_update_8061() {
   

   Do we already provide inter-drupal updates?

No inter-drupal updates at this point.

There is nothing in core anymore which is called 'route_set', so yeah!

Updated issue summary.

git ac https://drupal.org/files/2102417-15.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11957  100 11957    0     0   5908      0  0:00:02  0:00:02 --:--:--  6487
error: patch failed: core/lib/Drupal/Core/Routing/RouteBuilder.php:84
error: core/lib/Drupal/Core/Routing/RouteBuilder.php: patch does not apply

Back to rtbc

+++ b/core/lib/Drupal/Core/Routing/RouteBuilder.php
@@ -119,7 +119,7 @@ public function rebuild() {
-    $this->dumper->dump(array('route_set' => 'dynamic_routes'));
+    $this->dumper->dump(array('provider' => 'dynamic_routes'));

Does this mean we can't have a module named dynamic_routes?

alexpott: Yes. That's been the case for over a year now. It's unrelated to this issue.

git ac https://drupal.org/files/issues/2102417-21.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13205  100 13205    0     0   6724      0  0:00:01  0:00:01 --:--:--  9817
error: core/modules/system/lib/Drupal/system/Tests/Routing/RoutingFixtures.php: does not exist in index

Rerolled.

And back.

Committed 8e729c3 and pushed to 8.x. Thanks!

Thank you!